Bug 97304 – SourcesHelper recalcs ext roots after any prop change

[?]
| New
| Browse
| Search
| Reports
| Help
| Log In

Bug 97304 - SourcesHelper recalcs ext roots after any prop change


Summary:	SourcesHelper recalcs ext roots after any prop change

Status:	NEW

Product:	projects
Classification:	Unclassified
Component:	Ant Project
Version:	6.x
Hardware:	All All

Priority:	P4 (vote)
Target Milestone:	TBD
Assigned To:	Milos Kleint
QA Contact:	issues@projects

URL:
Whiteboard:
Keywords:	PERFORMANCE

Depends on:	98732
Blocks:	49026
	Show dependency tree / graph

Reported:	2007-03-06 17:57 UTC by Jesse Glick
Modified:	2013-01-14 14:09 UTC (History)
CC List:	1 user (show)

See Also:
Issue Type:	DEFECT
Exception Report :

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jesse Glick 2007-03-06 17:57:57 UTC

070305. Can be slow for unrooted includes. E.g. following is after changing
unrelated prop (compiler args):

   java.lang.Thread.State: RUNNABLE
	at java.io.UnixFileSystem.getBooleanAttributes0(Native Method)
	at java.io.UnixFileSystem.getBooleanAttributes(UnixFileSystem.java:228)
	at java.io.File.isDirectory(File.java:754)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:260)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.findMatches(PathMatcher.java:275)
	at
org.netbeans.spi.project.support.ant.PathMatcher.computeKnownIncludes(PathMatcher.java:246)
	at org.netbeans.spi.project.support.ant.PathMatcher.<init>(PathMatcher.java:107)
	at
org.netbeans.spi.project.support.ant.SourcesHelper$SourceRoot.computeIncludeExcludePatterns(SourcesHelper.java:227)
	at
org.netbeans.spi.project.support.ant.SourcesHelper$SourceRoot.getIncludeRoots(SourcesHelper.java:234)
	at
org.netbeans.spi.project.support.ant.SourcesHelper.remarkExternalRoots(SourcesHelper.java:488)
	at
org.netbeans.spi.project.support.ant.SourcesHelper.access$1200(SourcesHelper.java:67)
	at
org.netbeans.spi.project.support.ant.SourcesHelper$PropChangeL.propertyChange(SourcesHelper.java:744)
	at
org.openide.util.WeakListenerImpl$PropertyChange.propertyChange(WeakListenerImpl.java:161)
	at
org.netbeans.spi.project.support.ant.PropertyUtils$SequentialPropertyEvaluator.stateChanged(PropertyUtils.java:863)
	at org.openide.util.WeakListenerImpl$Change.stateChanged(WeakListenerImpl.java:294)
	at
org.netbeans.spi.project.support.ant.ProjectProperties$PP$2.run(ProjectProperties.java:326)
	at
org.netbeans.spi.project.support.ant.ProjectProperties$PP$2.run(ProjectProperties.java:324)
	at org.openide.util.Mutex.readAccess(Mutex.java:230)
	at
org.netbeans.spi.project.support.ant.ProjectProperties$PP.fireChange(ProjectProperties.java:333)
	at
org.netbeans.spi.project.support.ant.ProjectProperties$PP.diskChange(ProjectProperties.java:352)
	at
org.netbeans.spi.project.support.ant.ProjectProperties$PP.fileModified(ProjectProperties.java:367)
	at
org.netbeans.modules.project.ant.FileChangeSupport$Holder.someChange(FileChangeSupport.java:155)
	at
org.netbeans.modules.project.ant.FileChangeSupport$Holder.fileChanged(FileChangeSupport.java:170)
	at org.openide.filesystems.FCLSupport.dispatchEvent(FCLSupport.java:81)
	at org.openide.filesystems.FileObject$ED.dispatch(FileObject.java:856)
	at org.openide.filesystems.EventControl.invokeDispatchers(EventControl.java:181)
	at org.openide.filesystems.EventControl.exitAtomicAction(EventControl.java:155)
	at org.openide.filesystems.EventControl.runAtomicAction(EventControl.java:100)
	at org.openide.filesystems.FileSystem.runAtomicAction(FileSystem.java:471)
	at
org.netbeans.spi.project.support.ant.ProjectProperties$PP.write(ProjectProperties.java:215)
	at
org.netbeans.spi.project.support.ant.ProjectProperties.write(ProjectProperties.java:121)
	at
org.netbeans.spi.project.support.ant.AntProjectHelper.save(AntProjectHelper.java:565)
	- locked <0xa9625870> (a java.util.HashSet)
	at
org.netbeans.spi.project.support.ant.AntProjectHelper.access$100(AntProjectHelper.java:69)
	at
org.netbeans.spi.project.support.ant.AntProjectHelper$1.save(AntProjectHelper.java:107)
	at
org.netbeans.modules.project.ant.AntBasedProjectFactorySingleton.saveProject(AntBasedProjectFactorySingleton.java:191)