This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 85257 - I18N - Local diff show ghost character if file encoding is not OS's native.
Summary: I18N - Local diff show ghost character if file encoding is not OS's native.
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords: I18N
: 106438 106448 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-19 18:34 UTC by abs
Modified: 2007-10-01 19:50 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot of ghost character (5.28 KB, application/octet-stream)
2006-09-19 18:38 UTC, abs
Details
image (158.47 KB, image/gif)
2007-07-09 18:39 UTC, Ken Frank
Details

Note You need to log in before you can comment on or make changes to this bug.
Description abs 2006-09-19 18:34:20 UTC
Local diff can't handle encoding correctly. If file encoding is different from
OS's native, character become ghost.

This problem is not occured on Remote vs Local. And this problem may relate to
following issue.
http://www.netbeans.org/issues/show_bug.cgi?id=42638
Comment 1 abs 2006-09-19 18:38:23 UTC
Created attachment 34176 [details]
screenshot of ghost character
Comment 2 Tomas Stupka 2007-01-09 12:39:44 UTC
the same was already fixed in cvs. should work the same way
Comment 3 Tomas Stupka 2007-06-01 10:34:55 UTC
wasn't fixed in cvs - must be fixed generally for versioning
Comment 4 Tomas Stupka 2007-06-13 09:34:00 UTC
*** Issue 106436 has been marked as a duplicate of this issue. ***
Comment 5 Tomas Stupka 2007-06-13 09:35:29 UTC
*** Issue 106448 has been marked as a duplicate of this issue. ***
Comment 6 Tomas Stupka 2007-06-13 09:35:44 UTC
*** Issue 106438 has been marked as a duplicate of this issue. ***
Comment 7 Tomas Stupka 2007-06-28 17:06:10 UTC
first part


Checking in META-INF/services/org.netbeans.spi.queries.FileEncodingQueryImplementation;
/cvs/versioncontrol/util/src/META-INF/services/org.netbeans.spi.queries.FileEncodingQueryImplementation,v  <-- 
org.netbeans.spi.queries.FileEncodingQueryImplementation
initial revision: 1.1


Checking in org/netbeans/modules/versioning/util/Utils.java;
/cvs/versioncontrol/util/src/org/netbeans/modules/versioning/util/Utils.java,v  <--  Utils.java
new revision: 1.5; previous revision: 1.4


Checking in org/netbeans/modules/versioning/util/queries/DiffFileEncodingQueryImpl.java;
/cvs/versioncontrol/util/src/org/netbeans/modules/versioning/util/queries/DiffFileEncodingQueryImpl.java,v  <-- 
DiffFileEncodingQueryImpl.java
initial revision: 1.1

Comment 9 Tomas Stupka 2007-06-29 00:36:23 UTC
fixed also for cvs, lost the commit output. sorry for that

fixed

Comment 10 Ken Frank 2007-07-06 19:40:52 UTC
I can't get the left side of the local history to show now in any case - is there a separate
problem with diff viewer ?  (or am I not doing what is needed to have diffs shown ?)

I have modified the java file, adding some lines, deleting others and saving but only
get one result and thus only the right side of the viewer shows the current file,
nothing on the left side.

ken.frank@sun.com
Comment 11 Tomas Stupka 2007-07-09 12:43:19 UTC
hm, i didn't have this problem in last daily. what's your build?
Comment 12 Ken Frank 2007-07-09 16:51:34 UTC
build 0706 is what I am using.

are there certain steps that need to be done to impact local history
(vs any changes at all ?)

ken.frank@sun.com
Comment 13 Tomas Stupka 2007-07-09 18:01:25 UTC
changing and save should be enough.
how exactly looks the right side. could you attach a screenshot?

thanks
Comment 14 Tomas Stupka 2007-07-09 18:02:05 UTC
i mean the left side, of course :)
Comment 15 Ken Frank 2007-07-09 18:38:07 UTC
attached is gif of left and right side - I have added lines, deleted lines, saved and also closed the
file in editor and reopened it.

but nothing shown on left side.

ken.frank@sun.com
Comment 16 Ken Frank 2007-07-09 18:39:07 UTC
Created attachment 44840 [details]
image
Comment 17 Ken Frank 2007-07-09 18:50:20 UTC
multibyte name of project or class or in comments does not impact this as per my last comment -
it happens even if no mbyte in project/class name or text of the file.

ken.frank@sun.com
Comment 18 Tomas Stupka 2007-07-09 18:57:10 UTC
any exceptions in your messages.log?
Comment 19 Ken Frank 2007-07-09 19:17:19 UTC
no exceptions in log.
Comment 20 Ken Frank 2007-07-09 19:17:48 UTC
ran in english locale - same problem
Comment 21 Ken Frank 2007-07-10 05:41:14 UTC
should a separate issue be filed ?

ken.frank@sun.com
Comment 22 Tomas Stupka 2007-07-10 10:14:57 UTC
- yes. i need as much info about your setup as possible, attach also your messages.log file, please

- do you get this with different files and with files which have more then one revision in the history?

- did you try to change the selection in the view, by selecting different lines in the table? (It's enough to select the
folder node specifying the day (today, 1 day ago, etc.) and then the node representing the actual file revision)

thanks


 
Comment 23 Ken Frank 2007-07-10 16:20:59 UTC
reopening as per Tomas comments wrt to 
fix of 109216.  (that the fix needs to rollback this fix)

ken.frank@sun.com
Comment 24 Tomas Stupka 2007-07-10 16:36:27 UTC
my fault! the reopened issue wasn't this one but #105884.

sorry for the confusion:(

closing as this one should be ok.




Comment 25 Ken Frank 2007-10-01 19:50:22 UTC
verifying - see 106436 for details since these 2 appear to be duplicates.

if problems seen now with any one versioning system, then separate issues can be filed.

ken.frank@sun.com