This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 162565 - BracketCompleter failing
Summary: BracketCompleter failing
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Actions/Menu/Toolbar (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Miloslav Metelka
URL:
Keywords: REGRESSION
: 162571 162784 (view as bug list)
Depends on:
Blocks: 163128
  Show dependency tree
 
Reported: 2009-04-14 10:07 UTC by Petr Hejl
Modified: 2009-04-22 09:49 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hejl 2009-04-14 10:07:00 UTC
BraketCompleter tests are failing in both Groovy and PHP - no related changes were made though. Hg bisect says the
reason could be this changeset http://hg.netbeans.org/web-main/rev/fa07f7c7f370.

We are still investigating... Any idea what could be wrong?
Comment 1 Vladimir Voskresensky 2009-04-14 10:22:55 UTC
significant regression :-(
Without any changes from C++ team as well:
There are no more auto completion for "" () [] in C/C++ files
+ looks like it doesn't work in Java files as well
Comment 2 Petr Hejl 2009-04-14 11:27:23 UTC
Now I'm pretty sure that fa07f7c7f370 introduced this (tests pass ok in parent changeset).
Comment 3 Miloslav Metelka 2009-04-14 12:33:07 UTC
Should now be fixed. The annotation-registered action can't be overriden by kit.createActions() based overriding.
http://hg.netbeans.org/jet-main/rev/4be842dffeae
Comment 4 Quality Engineering 2009-04-15 07:45:36 UTC
Integrated into 'main-golden', will be available in build *200904150201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/4be842dffeae
User: Miloslav Metelka <mmetelka@netbeans.org>
Log: #162565 - BracketCompleter failing.
Comment 5 Petr Hejl 2009-04-15 09:38:41 UTC
Some of the tests are fixed others are still failing in both PHP and Groovy (such as testDelete...).
Comment 6 Miloslav Metelka 2009-04-15 10:51:42 UTC
OK I will re-check the kits and overridings and make sure the tests don't fail anymore.
Comment 7 Miloslav Metelka 2009-04-15 14:33:39 UTC
There are now only 2 failing tests in PHPFormatterTest which should be unrelated to this change.
Changeset: 01f2484a83f7
Comment 8 Miloslav Metelka 2009-04-15 14:38:58 UTC
*** Issue 162571 has been marked as a duplicate of this issue. ***
Comment 9 brettryan 2009-04-15 16:40:47 UTC
Camel case navigation for java is still broken in 200904150201 - Java SE bundle.
Comment 10 brettryan 2009-04-16 11:53:14 UTC
Camel case navigation for java is still broken in 200904160201 - Java SE bundle.
Comment 11 Miloslav Metelka 2009-04-16 12:08:11 UTC
Maybe the changeset did not propagate yet? I'll check that. But I had checked the camel case navigation before the integration so I'm confident that it should 
work properly.
Comment 12 Vladimir Voskresensky 2009-04-16 13:22:04 UTC
just a note: in cnd-main it was propagated correctly and camel case works fine again...
Comment 13 Quality Engineering 2009-04-16 19:18:33 UTC
Integrated into 'main-golden', will be available in build *200904161401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/01f2484a83f7
User: Miloslav Metelka <mmetelka@netbeans.org>
Log: #162565 - BracketCompleter failing - additional fix for camel case actions and editor actions listing in blacklist.txt
Comment 14 Tomasz Slota 2009-04-17 07:40:55 UTC
*** Issue 162784 has been marked as a duplicate of this issue. ***
Comment 15 brettryan 2009-04-21 06:17:00 UTC
Confirmed fixed in 200904201507 Java SE version.

Much appreciated for this one :)