This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 239792

Summary: Inconsistent deactivation of Apply button across Option panels
Product: platform Reporter: MackSix
Component: Options&SettingsAssignee: Theofanis Oikonomou <theofanis>
Status: VERIFIED FIXED    
Severity: normal CC: MackSix, markiewb
Priority: P2 Keywords: UMBRELLA
Version: 8.0   
Hardware: PC   
OS: Windows 7   
Issue Type: DEFECT Exception Reporter:
Bug Depends on: 239924, 239934, 239948, 239949, 239950, 239951, 239964, 239965, 239966, 239968, 239969, 239992, 239993, 240008, 240009, 240046, 240047, 240048, 240049, 240050, 240086, 240087, 240126, 240128, 240231, 240232, 240233, 240234, 240235, 240236, 240237, 240238, 240239, 240240, 240241, 240423, 240424, 240425, 240426, 240427, 240429, 240579, 240580, 240581, 240582, 240583, 240584, 240585, 240586, 240587, 240588, 240589, 240590, 240591, 240618, 240619, 240620, 240621, 240719, 240879, 240885, 240886, 240887, 240888, 240889, 240890, 240976, 240984, 241119, 241124, 241182, 241183, 241184, 241185, 241186    
Bug Blocks:    

Description MackSix 2013-12-25 14:25:55 UTC
In Tools >> Options dialog, some panels will deactivate the Apply button after it has been activated by changing an option. For example the Java >> Profiler tab works this way but the Maven tab does not.

Product Version: NetBeans IDE Dev (Build 201312230002)
Java: 1.8.0-ea; Java HotSpot(TM) 64-Bit Server VM 25.0-b60
Runtime: Java(TM) SE Runtime Environment 1.8.0-ea-b118
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
Comment 1 MackSix 2013-12-25 14:28:32 UTC
Step:

1. Goto Tools >> Options >> Profiler tab.
2. Check "CPU" and notice the Apply button is enabled.
3. Uncheck "CPU" and notice the Apply button is disabled.

This behavior does not occur on the Maven tab and many other panels. Once the Apply button is checked on the Maven tab--unchecking the option does not deactivate the Apply button.
Comment 2 Theofanis Oikonomou 2013-12-27 13:01:48 UTC
This is true. This should be filed separately for each panel that you see that has this behaviour. 

IMHO if any option in any panel changes then the panel's option controller should return true to the options infrastructure so that it would activate the Apply button. 

If then all options in that panel are changed back by the user to the "original" values then again the controller should let the infrastructure know about this fact, when asked, so that it would deactivate the Apply button. Thank you for reporting
Comment 3 Theofanis Oikonomou 2014-01-02 13:01:14 UTC
On second thought I guess this should be handled in one place to guarantee consistent behavior. stay tuned :)
Comment 4 Theofanis Oikonomou 2014-01-02 14:11:13 UTC
I am marking this as an umbrella issue and will add dependent issues that will be later filed against individual components that do not behave consistently when it comes to enabling/disabling Apply button to have better control of what components will be affected.
Comment 5 MackSix 2014-01-02 18:31:40 UTC
(In reply to Theofanis Oikonomou from comment #4)
> I am marking this as an umbrella issue and will add dependent issues that
> will be later filed against individual components that do not behave
> consistently when it comes to enabling/disabling Apply button to have better
> control of what components will be affected.

Should anyone else file individual component issues and add them here or are you going to go through and file each issue yourself?
Comment 6 Theofanis Oikonomou 2014-01-03 09:53:02 UTC
(In reply to MackSix from comment #5)
> Should anyone else file individual component issues and add them here or are
> you going to go through and file each issue yourself?

I plan to go through all the panels myself but any help in filing individual issues and/or verify the fixes is more than welcomed :)
Comment 7 Theofanis Oikonomou 2014-02-03 16:19:41 UTC
Since all individual panels were changed to correctly enable/disable the Apply button this one can be closed as fixed. While verifying if something does not work as expected please file a new bug. Thank you for reporting.
Comment 8 MackSix 2014-02-03 16:45:46 UTC
(In reply to Theofanis Oikonomou from comment #7)
> Since all individual panels were changed to correctly enable/disable the
> Apply button this one can be closed as fixed. While verifying if something
> does not work as expected please file a new bug. Thank you for reporting.

Wow, you did it! Congratulations. :)
Comment 9 MackSix 2014-02-21 06:40:50 UTC
I know all this is fixed now in:

Product Version: NetBeans IDE Dev (Build 201402200001)
Updates: Updates available
Java: 1.8.0; Java HotSpot(TM) 64-Bit Server VM 25.0-b69
Runtime: Java(TM) SE Runtime Environment 1.8.0-b128
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)