Changeset: 65ae4d11149e
Author:    Theofanis Oikonomou <theofanis@netbeans.org>
Date:      2014-01-09 18:54
Message:

Integrated into 'main-silver', will be available in build *201401110002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/65ae4d11149e
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Task #240048 - Inconsistent activation/deactivation of Apply button from Fonts & Colors->Annotations options panel

Effects & Effect Color on the Categories: "Error", "Notice" and "Warning" (The ones with no icons) does not activate the Apply button.

Product Version: NetBeans IDE Dev (Build 201401260001)
Java: 1.8.0-ea; Java HotSpot(TM) 64-Bit Server VM 25.0-b65
Runtime: Java(TM) SE Runtime Environment 1.8.0-ea-b123
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)

Actually, this only occurs on a new installation or a new userdir. 

Once an Effect Color is changed and the OK button is clicked, the Apply button will start working, but it does not deactivate until it is clicked a second time. After that it will deactivate. 

Also, if the Effect Color is changed to Yellow, the Effect will always get set to "None". This is unexpected.

Changeset: 87507eaa2e74
Author:    Theofanis Oikonomou <theofanis@netbeans.org>
Date:      2014-01-27 12:17
Message:

(In reply to MackSix from comment #3)
> Effects & Effect Color on the Categories: "Error", "Notice" and "Warning"
> (The ones with no icons) does not activate the Apply button.

You need to select an effect and the effect's color. It works for me this way.

(In reply to MackSix from comment #4)
> 
> Also, if the Effect Color is changed to Yellow, the Effect will always get
> set to "None". This is unexpected.

This should be fixed now. Thank you for catching this

(In reply to Theofanis Oikonomou from comment #6)
> (In reply to MackSix from comment #3)
> > Effects & Effect Color on the Categories: "Error", "Notice" and "Warning"
> > (The ones with no icons) does not activate the Apply button.
> 
> You need to select an effect and the effect's color. It works for me this
> way.

I realize that and it still has problems. This is what I see:

1. Goto Fonts & Colors >> Annotations; Category: Error (with no icon)
Default shows:
Effects: Wave Underlined
Effect Color: Red

2. Change to None; Apply button does not activate.

1. Goto Fonts & Color >> Highlighting; Category: Hyperlinks
Default shows:
Effects: Underlined
Effect Color: Blue

1. Change to Wave Underlined; Apply button activates as expected. (do not click Apply button)
2. Change to Strike Through; Apply button deactivates, but it should stay activated.
3. Choose a new color (Cyan); Apply button still stays deactivated although it should be activated.
4. Choose Wave Underlined; Apply button activates.
5. Choose None; Apply button deactivates, but it should be activated.
6. Choose Wave Underlined and Cyan again and click Apply and then click back on Hyperlinks again.
7. Apply button reactivates, click Apply again. (having to click Apply button twice here always happens with new userdir first time)
8. Choose Strike Through; Apply button activates as it should.
9. Choose Underline and None and Apply button stays activated as it should.
10. Choose Strike Through and Magenta; click Apply button.
11. Click back on Hyperlinks again and Effects is None although it should be Strike Through.
12. Choose Underlined and Green; click Apply button.
13. Click back on Hyperlinks
14. Choose Strike Through and Apply button does not Activate again, even if green is chosen again or another color.

Changeset: 70ac207789ca
Author:    Theofanis Oikonomou <theofanis@netbeans.org>
Date:      2014-01-27 16:52
Message:

(In reply to MackSix from comment #7)
> (In reply to Theofanis Oikonomou from comment #6)
> > (In reply to MackSix from comment #3)
> > > Effects & Effect Color on the Categories: "Error", "Notice" and "Warning"
> > > (The ones with no icons) does not activate the Apply button.
> > 
> > You need to select an effect and the effect's color. It works for me this
> > way.
> 
> I realize that and it still has problems. This is what I see:

oups sorry I missed that part! now I believe that it works just fine :)

Integrated into 'main-silver', will be available in build *201401280001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/87507eaa2e74
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Task #240048 - Inconsistent activation/deactivation of Apply button from Fonts & Colors->Annotations options panel

It works ok now, except on the Annotations panel, the Apply button is enabled going from none to Wave Underline without choosing a color, whilst this works OK (must choose a color) on the Highlighting panel.

Product Version: NetBeans IDE Dev (Build 201401280001)
Java: 1.8.0-ea; Java HotSpot(TM) 64-Bit Server VM 25.0-b66
Runtime: Java(TM) SE Runtime Environment 1.8.0-ea-b124
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)

(In reply to MackSix from comment #11)
> It works ok now, except on the Annotations panel, the Apply button is
> enabled going from none to Wave Underline without choosing a color, whilst
> this works OK (must choose a color) on the Highlighting panel.
> 
> Product Version: NetBeans IDE Dev (Build 201401280001)
> Java: 1.8.0-ea; Java HotSpot(TM) 64-Bit Server VM 25.0-b66
> Runtime: Java(TM) SE Runtime Environment 1.8.0-ea-b124
> System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)

hHmmm, I cannot reproduce in Build 20140128-e4c4f91aef46.
Started with clean userdir. enabled j2se. went to Options->F&C->Annotations.
Selected Ant targets category, although the same happened with any category I selected, and changed None to Wave underlined. The Apply button did not activate until I selected a color. Can you still reproduce with these step?

(In reply to Theofanis Oikonomou from comment #12)
> (In reply to MackSix from comment #11)
> > It works ok now, except on the Annotations panel, the Apply button is
> > enabled going from none to Wave Underline without choosing a color, whilst
> > this works OK (must choose a color) on the Highlighting panel.
> > 
> > Product Version: NetBeans IDE Dev (Build 201401280001)
> > Java: 1.8.0-ea; Java HotSpot(TM) 64-Bit Server VM 25.0-b66
> > Runtime: Java(TM) SE Runtime Environment 1.8.0-ea-b124
> > System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
> 
> hHmmm, I cannot reproduce in Build 20140128-e4c4f91aef46.
> Started with clean userdir. enabled j2se. went to Options->F&C->Annotations.
> Selected Ant targets category, although the same happened with any category
> I selected, and changed None to Wave underlined. The Apply button did not
> activate until I selected a color. Can you still reproduce with these step?

I think something was corrupted about my installation due to features-on-demand activation. I didn't have an Ant target in the list, although JavaSE was activated. I removed userdir and cachedir and ran NetBeans again and activated GUI Builder, PHP and C/C++ on their Options panel and had the same problem. Then I deactivated them by restarting 5 or 6 times and then activated them through the plugin manager and the Apply button started working OK. I removed the userdir & cachedir several more times and tried activating through the Options panel and could not get it to break again. 

I also saw a problem when the features-on-demand auto-deactivation occurred. I do not know if it is related, but about 2 out of 5 times, right after everything was deactivated by restarting NetBeans 5 or 6 times with no projects open, I would then shutdown NetBeans and delete the userdir, restart and then try to activate features through the Options panel and when I clicked the Activate button, the whole panel would changed to a big JButton and nothing would happen. Same thing occured on the GUI Builder panel, PHP and C/C++ panel. I went to the plugin manager and it showed they were all activated, although they were not. I deactivated them there and reactivated them and they would activate.