Changeset: 5cb5e44d9f5e
Author:    Theofanis Oikonomou <theofanis@netbeans.org>
Date:      2014-02-03 17:18
Message:

Integrated into 'main-silver', will be available in build *201402040001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/5cb5e44d9f5e
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Task #241182 - Inconsistent activation/deactivation of Apply button from C/C++->Build Tools options panel

Please redo or rollback the fix. It result in bug #241753.

Error in:
   ToolsCacheManagerImpl tcm = (ToolsCacheManagerImpl) ToolsPanelSupport.getToolsCacheManager();
    ToolsCacheManagerImpl savedTCM = (ToolsCacheManagerImpl) ToolsPanelSupport.getToolsCacheManager();

Two objects are same.

Created attachment 145087 [details]
proposed patch

will apply the patch for bug 241753 asap. Sorry for this. Thank you

(In reply to Theofanis Oikonomou from comment #6)
> will apply the patch for bug 241753 asap. Sorry for this. Thank you
Other regression is:
        Iterator<? extends ServerRecord> savedHostsIter = savedHosts.iterator();
        Iterator<? extends ServerRecord> currentHostsIter = currentHosts.iterator();
        while(savedHostsIter.hasNext()) {
            if (!savedHostsIter.next().getExecutionEnvironment().equals(currentHostsIter.next().getExecutionEnvironment())) {
                return true;
            }
        }
Compared only execution environment.
Should be compared also following attributes of ServerRecord:
- authentication
- SSH key
- Display name
- Access type
- X11 forwarding
- Path mapper

(In reply to Alexander Simon from comment #7)
> (In reply to Theofanis Oikonomou from comment #6)
> > will apply the patch for bug 241753 asap. Sorry for this. Thank you
> Other regression is:
>         Iterator<? extends ServerRecord> savedHostsIter =
> savedHosts.iterator();
>         Iterator<? extends ServerRecord> currentHostsIter =
> currentHosts.iterator();
>         while(savedHostsIter.hasNext()) {
>             if
> (!savedHostsIter.next().getExecutionEnvironment().equals(currentHostsIter.
> next().getExecutionEnvironment())) {
>                 return true;
>             }
>         }
> Compared only execution environment.
> Should be compared also following attributes of ServerRecord:
> - authentication
> - SSH key
> - Display name
> - Access type
> - X11 forwarding
> - Path mapper

will add the extra checks asap. Thank you for pointing this out.

(In reply to Theofanis Oikonomou from comment #8)
> 
> will add the extra checks asap. Thank you for pointing this out.

filed this as bug 241777