This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 83520 - New Sun Deployment Descriptor wizard does not work for ear submodules in Archive Project
Summary: New Sun Deployment Descriptor wizard does not work for ear submodules in Arch...
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Archiveproject (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Vince Kraemer
URL:
Keywords:
: 78699 (view as bug list)
Depends on: 84544
Blocks:
  Show dependency tree
 
Reported: 2006-08-26 01:27 UTC by _ pcw
Modified: 2006-09-29 01:51 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
patch (28.01 KB, application/octet-stream)
2006-09-18 18:58 UTC, Vince Kraemer
Details
Radko's comment (2.38 KB, text/plain)
2006-09-27 19:11 UTC, Vince Kraemer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description _ pcw 2006-08-26 01:27:34 UTC
Given an EAR w/ sub modules that do not have their respective sun-???.xml file,
the new Sun Deployment Descriptor wizard only handles creation of the top level
sun-application.xml.  There is no way to create the sun-application-client.xml,
sun-ejb-jar.xml, or sun-web.xml (this one is still default though).
Comment 1 _ pcw 2006-08-26 01:30:28 UTC
Vince, I can fix this, but will have to work with you on how to do it.  Can you
think about the issue and reassign to me after considering options?

There are a few subissues - (1) the "config for XXX" nodes have a <New> item,
but it only offers DB schema.  Not sure if it should include <Sun Dep.
Descriptor> but I think it should if possible.

(2) Top level <New...> does offer the template, but when invoked that way, the
wizard only identifies the sun-application.xml target without considering
children.  I'm not sure if the wizard at this level should consider the child
modules or not - we should talk about this.
Comment 2 Vince Kraemer 2006-08-29 23:38:25 UTC
The New item needs to be re-examined here.  adding
templateCategory==deployment-descriptor to templates that "make sense" for the
packaged archive sub project. Make changes in web/ejb/appclient project modules
to  provide more refined list of RecommendedTemplates and PrivilegedTemplates.
Comment 3 Vince Kraemer 2006-08-30 21:00:51 UTC
sent diffs out to cdp-j2ee-dev for review.
Comment 4 Vince Kraemer 2006-09-15 21:47:11 UTC
Reviewers suggested api change that needed to go through review. Finalizing api
change Saturday.
Comment 5 Vince Kraemer 2006-09-18 18:58:19 UTC
Created attachment 34108 [details]
patch
Comment 6 Vince Kraemer 2006-09-18 19:20:50 UTC
checked into release55_dev
Comment 7 judytang 2006-09-19 22:39:43 UTC
I have used 9/19 NB release55_dev build to verify this issue.  Following is what
I have tested and found:

I created an archive project on a stateless ejb app then looked the following:

(1) Click on the app node->File/Folder-> Only Sun Deployment Descriptor can be
created
(2) Click on the war node->File/Folder-> Only Sun Deployment Descriptor can be
created
(3) Click on the ejb node->File/Folder-> both Sun Deployment Descriptor and
Standard Deployment Descriptor can be created

Question, should (1) and (2) also list the Standard Deployment Descriptor, so it
can be created just like (3) ?
Comment 8 judytang 2006-09-19 23:11:33 UTC
Got reply from Vince, Thanks Vince.  I am marking this issue as verified.

Yes, there should be, but there isn't such standard deployment descriptor
template for web.xml, application-client.xml or application.xml

The absence of these templates is really outside the scope of this issue. 
Comment 9 Vince Kraemer 2006-09-20 22:24:58 UTC
this should not be marked as verified yet... please see

http://jupiter.czech.sun.com/wiki/view/Netbeans/PromotionGBugFixing#2_High_Resistance_mode
Comment 10 Vince Kraemer 2006-09-20 22:25:47 UTC
needed to revert the verified flag
Comment 11 Vince Kraemer 2006-09-20 22:29:19 UTC
pcw... code review?
Comment 12 Martin Schovanek 2006-09-26 16:08:31 UTC
What is the status of this issue, can be integrated into release55 branch?
Comment 13 _ pcw 2006-09-26 17:27:12 UTC
Code looks fine to me.
Comment 14 Vince Kraemer 2006-09-27 16:55:41 UTC
*** Issue 78699 has been marked as a duplicate of this issue. ***
Comment 15 Vince Kraemer 2006-09-27 19:11:21 UTC
Created attachment 34612 [details]
Radko's comment
Comment 16 Vince Kraemer 2006-09-29 00:11:28 UTC
Checking in
db/model/src/org/netbeans/modules/dbschema/jdbcimpl/resources/mf-layer.xml;
/cvs/db/model/src/org/netbeans/modules/dbschema/jdbcimpl/resources/mf-layer.xml,v
 <--  mf-layer.xml
new revision: 1.4.26.2.2.3; previous revision: 1.4.26.2.2.2
done
Checking in
j2ee/archiveproject/src/org/netbeans/modules/j2ee/archive/ui/ModuleNode.java;
/cvs/j2ee/archiveproject/src/org/netbeans/modules/j2ee/archive/ui/Attic/ModuleNode.java,v
 <--  ModuleNode.java
new revision: 1.1.4.5; previous revision: 1.1.4.4
done
Checking in
j2ee/archiveproject/src/org/netbeans/modules/j2ee/archive/wizard/DeployableWizardIterator.java;
/cvs/j2ee/archiveproject/src/org/netbeans/modules/j2ee/archive/wizard/Attic/DeployableWizardIterator.java,v
 <--  DeployableWizardIterator.java
new revision: 1.1.2.21; previous revision: 1.1.2.20
done
Checking in
j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/AppClientProject.java;
/cvs/j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/Attic/AppClientProject.java,v
 <--  AppClientProject.java
new revision: 1.1.4.25; previous revision: 1.1.4.24
done
Checking in
j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/api/AppClientProjectGenerator.java;
/cvs/j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/api/Attic/AppClientProjectGenerator.java,v
 <--  AppClientProjectGenerator.java
new revision: 1.1.4.21; previous revision: 1.1.4.20
done
Checking in
j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/customizer/AppClientProjectProperties.java;
/cvs/j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/customizer/Attic/AppClientProjectProperties.java,v
 <--  AppClientProjectProperties.java
new revision: 1.1.4.20; previous revision: 1.1.4.19
done
Checking in j2ee/ejbcore/src/org/netbeans/modules/j2ee/ejbcore/resources/layer.xml;
/cvs/j2ee/ejbcore/src/org/netbeans/modules/j2ee/ejbcore/resources/layer.xml,v 
<--  layer.xml
new revision: 1.1.2.6.2.8; previous revision: 1.1.2.6.2.7
done
Checking in
j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/EjbJarProject.java;
/cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/EjbJarProject.java,v
 <--  EjbJarProject.java
new revision: 1.50.2.6.2.34; previous revision: 1.50.2.6.2.33
done
Checking in
j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/api/EjbJarProjectGenerator.java;
/cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/api/EjbJarProjectGenerator.java,v
 <--  EjbJarProjectGenerator.java
new revision: 1.1.2.6.2.15; previous revision: 1.1.2.6.2.14
done
Checking in
j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/EjbJarProjectProperties.java;
/cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/EjbJarProjectProperties.java,v
 <--  EjbJarProjectProperties.java
new revision: 1.27.2.3.2.11; previous revision: 1.27.2.3.2.10
done
Checking in
j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/layer.xml;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/Attic/layer.xml,v
 <--  layer.xml
new revision: 1.1.2.9.2.19; previous revision: 1.1.2.9.2.18
done
Checking in
serverplugins/sun/sunddui/src/org/netbeans/modules/j2ee/sun/share/layer.xml;
/cvs/serverplugins/sun/sunddui/src/org/netbeans/modules/j2ee/sun/share/layer.xml,v
 <--  layer.xml
new revision: 1.1.2.1.2.3; previous revision: 1.1.2.1.2.2
done
Checking in web/project/src/org/netbeans/modules/web/project/WebProject.java;
/cvs/web/project/src/org/netbeans/modules/web/project/WebProject.java,v  <-- 
WebProject.java
new revision: 1.85.2.3.2.41; previous revision: 1.85.2.3.2.40
done
Checking in
web/project/src/org/netbeans/modules/web/project/api/WebProjectCreateData.java;
/cvs/web/project/src/org/netbeans/modules/web/project/api/Attic/WebProjectCreateData.java,v
 <--  WebProjectCreateData.java
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in
web/project/src/org/netbeans/modules/web/project/api/WebProjectUtilities.java;
/cvs/web/project/src/org/netbeans/modules/web/project/api/WebProjectUtilities.java,v
 <--  WebProjectUtilities.java
new revision: 1.2.2.5.2.19; previous revision: 1.2.2.5.2.18
done
Checking in
web/project/src/org/netbeans/modules/web/project/ui/customizer/WebProjectProperties.java;
/cvs/web/project/src/org/netbeans/modules/web/project/ui/customizer/WebProjectProperties.java,v
 <--  WebProjectProperties.java
new revision: 1.94.6.3.2.9; previous revision: 1.94.6.3.2.8
Comment 17 judytang 2006-09-29 01:51:17 UTC
I have used 9/28 NB release55 build to verify this issue.  Following is what
I have tested and seen.  I am marking this as verified.

I created an archive project on a stateless ejb app then looked the following:

(1) Click on the app node->File/Folder-> Only Sun Deployment Descriptor can be
created
(2) Click on the war node->File/Folder-> Only Sun Deployment Descriptor can be
created
(3) Click on the ejb node->File/Folder-> both Sun Deployment Descriptor and
Standard Deployment Descriptor can be created