Date: Sat, 23 Sep 2006 23:04:46 +0200
From: Radko Najman <Radko.Najman@Sun.COM>
Subject: Re: another review request
In-reply-to: <451408DF.6000801@sun.com>
Sender: Radko.Najman@Sun.COM
To: vince kraemer <Vince.Kraemer@Sun.COM>
Message-id: <4515A16E.7030503@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
References: <451408DF.6000801@sun.com>
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
Original-recipient: rfc822;Vince.Kraemer@Sun.COM

Hi Vince,

I'm just leaving for my vacation and at last moment I mentioned your 
review request. I quickly reviewed it and I think it is OK. My comment 
from my previous review was addressed so I agree with it. I don't have 
enough time to test it so before commiting it into release55 branch 
please make sure that it will not affect older projects. I mean that 
projects created with previous NetBeans versions without this new 
property will still work fine.

Thanks,
Radko


vince kraemer wrote:
> Radko,
> 
> I hate to burden you with this, since you already did the review 
> earlier, but the API change that you recommended moved the commit for 
> 83520 into the HR timeframe.
> 
> Would you be willing to review the diffs attached to 
> http://www.netbeans.org/issues/show_bug.cgi?id=84544 and 
> http://www.netbeans.org/issues/show_bug.cgi?id=83520?
> 
> The diff attached to 84544 is the api changes.
> 
> The diffs attached to 83520 resolve the issue (but are dependent on the 
> api change).
> 
> Thanks,
> vbk