This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 70263 - Prefer look&feel folder icon
Summary: Prefer look&feel folder icon
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords: UI
: 72478 (view as bug list)
Depends on: 80876 120624
Blocks:
  Show dependency tree
 
Reported: 2005-12-12 12:51 UTC by pzajac
Modified: 2007-10-31 17:26 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
icons (3.52 KB, image/gif)
2005-12-12 12:52 UTC, pzajac
Details
Nb50 u1 + jdk 1.5 (2.58 KB, image/png)
2006-02-13 16:46 UTC, pzajac
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pzajac 2005-12-12 12:51:01 UTC
[200512111900]
It is for Important Files folder and Modules. Look at the attached screenshot.
Comment 1 pzajac 2005-12-12 12:52:15 UTC
Created attachment 27737 [details]
icons
Comment 2 Jesse Glick 2005-12-12 19:13:31 UTC
Yup, it's pretty ugly on Windows.
Comment 3 Jesse Glick 2005-12-28 21:31:54 UTC
Will do it for the module logical view. For the suite logical view, I am not
sure what to do. May need an icon designer. Anyway, Martin put together the
original badged icon - perhaps he can recreate the badge by itself.
Comment 4 Jesse Glick 2005-12-28 21:35:49 UTC
First half:

Checking in ModuleLogicalView.java;
/cvs/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/ModuleLogicalView.java,v
 <--  ModuleLogicalView.java
new revision: 1.16; previous revision: 1.15
done
Comment 5 Jesse Glick 2006-01-18 21:44:33 UTC
Yarda recently made some patch to FolderNode which sounded very similar to this,
so take a look.
Comment 6 Martin Krauskopf 2006-01-19 12:48:35 UTC
Fixed.

Removing suite/resources/suiteModules.gif;
Removing suite/resources/suiteModulesOpened.gif;
suite/resources/module-badge.gif; 1.1
ui/ModuleLogicalView.java; 1.17 -> 1.18;
ui/SuiteLogicalView.java; 1.29 -> 1.30;
ui/UIUtil.java; 1.21 -> 1.22;
Comment 7 pzajac 2006-02-01 11:32:10 UTC
cannot reproduce - verified
Comment 8 Martin Krauskopf 2006-02-01 11:38:04 UTC
However if you would encounter "some" problem under non-default L&F be aware
about issue 72066.
Comment 9 Martin Krauskopf 2006-02-09 15:48:44 UTC
*** Issue 72478 has been marked as a duplicate of this issue. ***
Comment 10 pzajac 2006-02-09 16:36:28 UTC
reopened
Comment 11 Martin Krauskopf 2006-02-09 16:46:57 UTC
Sinc it works for me on Linux and for Tomas on Windows I need more information.
OS, L&F, JDK, ...
Comment 12 Tomas Danek 2006-02-13 12:42:49 UTC
I have the same apperenace in 5.0 with updated apisupport as on the picture that
Zajo posted. WinXP, JDK 1.6.0 b66.
I'm not really expert on LnF, so if you want some info concerning it, please
tell me where it can be found:)
Comment 13 Martin Krauskopf 2006-02-13 12:48:50 UTC
Yes, this is not fixed in 5.0. Can you try trunk build Tomasi?
Comment 14 Tomas Danek 2006-02-13 13:09:08 UTC
trunk is ok for me. Running with the same JDK
Comment 15 pzajac 2006-02-13 13:32:49 UTC
In trunk is different default folder icon then in nb 50. 
Comment 16 Martin Krauskopf 2006-02-13 13:47:37 UTC
Do you mean 5.0 or 5.0u1? TM == 5.0u1
Comment 17 Tomas Danek 2006-02-13 14:43:22 UTC
you are right, installing 50u1 nbms into 5.0 fixes the problem. Have no
objections now.
Comment 18 Martin Krauskopf 2006-02-13 15:16:23 UTC
Thanks. Maybe Zajo forgot to install 5.0u1 nbms when he tried BUILD.xml script.
Zajo if you still believe there is a bug in trunk or 5.0u1 (5.0 + 5.0u1 nbms)
feel free to reopen.
Comment 19 pzajac 2006-02-13 16:46:38 UTC
Created attachment 28861 [details]
Nb50 u1 + jdk 1.5
Comment 20 pzajac 2006-02-13 16:49:22 UTC
I am using jdk1.5, linux and nb50u1.  
Comment 21 Martin Krauskopf 2006-02-13 16:54:36 UTC
Aha. I understand now. Great confusion. So this is actually bug in DataLoader
which Jarda already fixed in trunk. But it is not fixed in 5.0. So our icons are
the right ones in this case. DataLoader's ones are bad.
So the question is should we revert our fix -> introduce the bug back and be
compatible with the bug in the DataLoader? :)
Comment 22 Martin Krauskopf 2006-02-13 17:00:31 UTC
> So the question is should we revert our fix -> introduce the bug back and be
> compatible with the bug in the DataLoader? :)

More precisely not revert since our icons were hardcoded. Rather to do a special
fix it in NB 5.0u1 simulating DataLoaders (little buggy) behaviour in 5.0.
Comment 23 pzajac 2006-02-13 17:31:30 UTC
Buggy compatibility looks much better than the correct implementation :-)
Comment 24 Martin Krauskopf 2006-02-13 18:23:00 UTC
Could you file a new issue (Version == 5.1u1) to prevent more confusion in this
one and to be sure it will not get forgotten. Thanks.
Comment 25 pzajac 2006-02-27 12:41:39 UTC
verified