This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 80876 - Wrong icons for Important Files and Libraries on Mac OS
Summary: Wrong icons for Important Files and Libraries on Mac OS
Status: RESOLVED DUPLICATE of bug 153523
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: rmichalsky
URL:
Keywords: UI
Depends on:
Blocks: 70263
  Show dependency tree
 
Reported: 2006-07-22 06:15 UTC by _ tboudreau
Modified: 2008-11-24 14:42 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2006-07-22 06:15:54 UTC
The icons for Important Files and Libraries are not correct on mac os - they are
Windows-style yellow folders instead of blue macintosh folders (I know how silly
that sounds).

Just borrow the icons from J2SE project for this - it has it right.
Comment 1 Jesse Glick 2006-07-28 15:06:53 UTC
So I'm a little confused here. Issue #70263 is claimed to be fixed already. But
no one tested on Mac OS X?

apisupport uses a quite complicated code path: first
Tree.closedIcon/Tree.openIcon if available; then
Nb.Explorer.Folder.icon/Nb.Explorer.Folder.openedIcon if available; finally
hardcoded folder icons. Then the folder icon is badged.

j2seproject, in contrast, applies a badge to the icons from
DataFolder.findFolder(Repository.getDefault().getDefaultFileSystem().getRoot()).getNodeDelegate(),
which will come from FolderNode.getIcon, which uses Nb.Explorer.Folder.icon and
Tree.closedIcon. Why FolderNode uses the generic UI key for the closed icon but
an NB-specific key for the open icon, I have no idea.

The j2seproject approach seems simpler and safer, as FolderNode will certainly
be maintained. Or someone could introduce a convenience API into org.openide.awt
somewhere:

public static Image getLafFolderIcon(boolean opened);

so we can fix this code in one place only. I'm sure there are other modules
which need to display pseudo-folders, with or without badges.
Comment 2 Martin Krauskopf 2006-07-31 09:29:31 UTC
There were some confusing discussion (issue 70263) and there were a bug in
DataLoaders as well which Jarda already fixed, I think. Also see issues 73049
(btw not verified under Mac OS) and maybe 72066. I'll have to evaluate more.
Thanks for the analysis Jesse.
Comment 3 Martin Krauskopf 2008-02-07 17:51:08 UTC
I'm not working on APISupport anymore. Reassigning to owner of the component, so
the issue is not 'forgotten' forever.
Comment 4 rmichalsky 2008-11-24 14:42:10 UTC

*** This issue has been marked as a duplicate of 153523 ***