This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 67314 - Suite evaluator doesn't return up-to-date values
Summary: Suite evaluator doesn't return up-to-date values
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords:
: 66480 66487 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-10-21 16:44 UTC by Martin Krauskopf
Modified: 2005-11-22 15:13 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
failed test (1.37 KB, text/plain)
2005-10-21 16:45 UTC, Martin Krauskopf 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Krauskopf 2005-10-21 16:44:23 UTC 
Attaching failure from (not yet commited)
SuiteProjectTest.testSuiteEvaluatorReturnsUpToDateValues(). Heavily random
however. Reproducible only on Solaris so far.
Also caused some (random) failures in other relative test. JDK 1.5.x specific.
If it fails for somebody on a different machine please report here.
If you any hints Jesse, please write them here. I don't know at all, what could
be wrong.
Comment 1 Martin Krauskopf 2005-10-21 16:45:19 UTC 
Created attachment 26228 [details]
failed test
Comment 2 Martin Krauskopf 2005-10-21 16:48:27 UTC 
Commited under SuiteProjectTest.testSuiteEvaluatorReturnsUpToDateValues_67314()
Comment 3 Martin Krauskopf 2005-10-21 16:50:55 UTC 
*** Issue 66487 has been marked as a duplicate of this issue. ***
Comment 4 Martin Krauskopf 2005-10-21 16:50:59 UTC 
*** Issue 66480 has been marked as a duplicate of this issue. ***
Comment 5 Martin Krauskopf 2005-10-21 16:52:30 UTC 
I really believe that SuitePropertiesTest and SuiteUtilsTest will be fixed
together with this one. If not, dupes will be reopened.
Comment 6 Martin Krauskopf 2005-10-24 11:58:52 UTC 
Radku please consider this one and also see dupes for more info. Since as you
tried it is relatively easily (maybe 100% for those dupes) reproducible also on
Windows. Since Solaris is not easily accessible for us and you have the best
access to Windows... ;) Thanks.
Comment 7 rmatous 2005-10-24 17:32:10 UTC 
Code in method ProjectProperies.fireChange after comment
"// Not safe to acquire a new lock, so run later in read access." seems to be
source of problem - may cause race condition.
Comment 8 Jesse Glick 2005-10-24 22:27:46 UTC 
The test is reporting an actual bug. The NbModuleProjectGenerator methods should
wrap their entire bodies in ProjectManager.mutex write access. Otherwise the
change event in the suite's project.properties arrives asynchronously. Thanx
Radek for finding the cause.
Comment 9 Martin Krauskopf 2005-10-25 17:59:51 UTC 
Thanks for the help, sorry for troubles. You know, one of my first apisupport
contributions.... who cares :) Will be done for 5.0 - as Radek told me this can
be cause of more "random" bugs in whole apisupport -> true -> P2.
Comment 10 Martin Krauskopf 2005-10-26 16:05:33 UTC 
Should be fixed. Radku could you run tests under Windows? I'll try Solaris
tomorrow. Thanks.

Checking in NbModuleProjectGenerator.java; 1.39 --> 1.40
Checking in suite/SuiteProjectGenerator.java; 1.8 --> 1.9
Comment 11 Martin Krauskopf 2005-10-27 13:23:12 UTC 
*** Issue 66387 has been marked as a duplicate of this issue. ***
Comment 12 Tomas Danek 2005-11-22 15:13:59 UTC 
passes now on my machine. Verified.