57791 – Deadlock in APH

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57791 - Deadlock in APH

Summary: Deadlock in APH

Status:	CLOSED FIXED

Alias:	None

Product:	projects
Classification:	Unclassified
Component:	Ant Project (show other bugs)
Version:	4.x
Hardware:	All All

Importance:	P2 blocker (vote)
Assignee:	Jesse Glick

URL:
Keywords:	THREAD

Depends on:
Blocks:	50198
	Show dependency tree

Reported:	2005-04-12 20:36 UTC by Jesse Glick
Modified:	2006-03-24 13:16 UTC (History)
CC List:	1 user (show)

See Also:
Issue Type:	DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jesse Glick 2005-04-12 20:36:24 UTC

Seems the fix of issue #50198 can cause deadlocks at least sometimes. Calling
FileLock.releaseLock() notifies listeners, so it should not be done while
holding a monitor.

Comment 1 Jesse Glick 2005-04-12 20:36:53 UTC

See details in issue #57480.

Comment 2 Jesse Glick 2005-04-12 22:17:14 UTC

Have patch; cannot reproduce deadlock with it applied, at least.

Comment 3 Jesse Glick 2005-04-13 00:23:52 UTC

Fixed w/ issue #57794:

committed   * Up-To-Date  1.29       
ant/project/src/org/netbeans/spi/project/support/ant/AntProjectHelper.java
committed   * Up-To-Date  1.12       
ant/project/src/org/netbeans/spi/project/support/ant/ProjectProperties.java

Comment 4 Jesse Glick 2005-04-13 00:31:42 UTC

Will need QA assistance.

Comment 5 Jesse Glick 2005-04-13 00:45:48 UTC

Diff incl. fix of issue #57794 (*after* issue #50198 patch):

http://www.netbeans.org/source/browse/ant/project/src/org/netbeans/spi/project/support/ant/AntProjectHelper.java?r1=1.28&r2=1.29
http://www.netbeans.org/source/browse/ant/project/src/org/netbeans/spi/project/support/ant/ProjectProperties.java?r1=1.11&r2=1.12

Comment 6 Jiri Kovalsky 2005-04-13 12:58:55 UTC

I have tried hard but couldn't reproduce the deadlock in continuous trunk build
#20050413-0713 of NetBeans 4.2. I agree with integration to release41 branch.

Comment 7 Jesse Glick 2005-04-15 19:43:28 UTC

Incl. issue #57794:

committed   * Up-To-Date  1.27.14.2  
ant/project/src/org/netbeans/spi/project/support/ant/AntProjectHelper.java
committed   * Up-To-Date  1.11.22.1  
ant/project/src/org/netbeans/spi/project/support/ant/ProjectProperties.java

Comment 8 Jiri Kovalsky 2005-04-18 13:31:56 UTC

Verified in RC1 candidate build #200504171930 of NetBeans 4.1.