This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57483 - Problems with closing document (Discard Changes).
Summary: Problems with closing document (Discard Changes).
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: XML Multiview (show other bugs)
Version: 4.x
Hardware: All All
: P2 blocker (vote)
Assignee: Milan Kuchtiak
URL:
Keywords:
Depends on:
Blocks: 57173 57313 57489
  Show dependency tree
 
Reported: 2005-04-05 14:53 UTC by Milan Kuchtiak
Modified: 2007-09-25 01:32 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Kuchtiak 2005-04-05 14:53:52 UTC 
If some changes are made in web.xml/ejb-jar.xml editor and user discards the
changes (Close -> Discard) several problems arise :

1. data model (schema2beans model) is not changed until editor is reopened
again, which is bad.
2. if the editor is reopened again it bahaves like not saved (issue 57313)
3. if editor is saved and edited again the save button is "forever" disabled

Either 1. or 2. is sufficient to be a P2.
Comment 2 _ ludo 2005-04-05 18:16:50 UTC 
Any implications on http://www.netbeans.org/issues/show_bug.cgi?id=57466

maybe not.
?
Comment 3 Milan Kuchtiak 2005-04-06 17:55:44 UTC 
There is another problem (similar to problem nr.3), not fixed yet.

4.problem :
Close web project with modified web.xml (use Close -> Discard All option in
Close dialog) and open it (I mean web project) again. 
- web.xml file is modified despite discarding changes
- the save button is "forever" disabled.

I noticed the same behaviour with sun-web.xml.

Although problems 1-3 were resolved, we should resolve the forth problem to
resolve the whole issue successfully.
Comment 4 Milan Kuchtiak 2005-04-07 15:14:16 UTC 
The last problem depends on issue 57610.
Comment 5 Milan Kuchtiak 2005-04-07 16:08:45 UTC 
Fixed also a problem with closing deserialized editor:
The deserialized editor (in XML view) can be closed without a warning.
Implemented in the same way as in Graphical view.

Diff:
http://xml.netbeans.org/source/browse/xml/multiview/src/org/netbeans/modules/xml/multiview/XmlMultiViewElement.java?r1=1.21&r2=1.22
Comment 6 Milan Kuchtiak 2005-04-07 16:28:58 UTC 
I've created a separate issue 57626 for problem nr.4.
Thus, I can remove the dependency on issue 57610.
All other problems are fixed in trunk.
Comment 7 zikmund 2005-04-07 16:33:14 UTC 
Fixed in trunk - correcting Resolution and Target milestone.
Comment 8 zikmund 2005-04-11 13:28:41 UTC 
Verified in 200504101800 trunk build.
Comment 9 zikmund 2005-04-11 13:33:44 UTC 
It is ready for release41 branch integration from QE point of view.

Now waiting only for patch review.
Comment 10 Pavel Fiala 2005-04-11 21:01:54 UTC 
I reviewed the fix and it is OK.
Comment 12 zikmund 2005-04-15 17:54:17 UTC 
Verified in 4.1 build 200504142205.