This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 55312 - Deploy/Redeploy action
Summary: Deploy/Redeploy action
Status: CLOSED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Web Project (show other bugs)
Version: 4.x
Hardware: PC All
: P3 blocker (vote)
Assignee: Pavel Buzek
URL: http://j2ee.netbeans.org//docs/enterp...
Keywords:
Depends on:
Blocks: 55778
  Show dependency tree
 
Reported: 2005-02-21 16:17 UTC by Libor Kotouc
Modified: 2006-03-24 13:07 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Libor Kotouc 2005-02-21 16:17:45 UTC
Context menu item on J2EE app should be Redeploy
instead of Deploy as for web/ejb modules.
Comment 1 Vince Kraemer 2005-02-22 17:36:42 UTC
Not according to the UI spec.

Assigning to jrojcek for more evaluation.  If the UI spec changes,
please note it and reassign the issue for fixing.
Comment 2 Libor Kotouc 2005-02-23 08:45:34 UTC
ok, there were differences in ejb/web/j2ee modules...I thought that
web module action was named according to UI spec....now web and ejb
modules have both Deploy action.
btw, nor Deploy neither Redeploy are clear in their meaning.
Comment 3 jrojcek 2005-03-02 11:03:30 UTC
All the specs now say Deploy.
Comment 4 Geertjan Wielenga 2005-03-02 11:53:48 UTC
Ok, so now we have two items: "Run" and "Deploy".

Everything I know about the difference between "Run" and "Redeploy" is
contained in this by Pavel:

http://www.netbeans.org/servlets/ReadMsg?msgId=888021&listName=nbj2ee

So, I am assuming that the difference between "Run" and "Deploy" is
still as described in Pavel's message, i.e., that "Run" takes the
minimal steps needed for running an app (i.e., moving only the changed
files to the server) while "Deploy" undeploys and then redeploys the
application.

If the above distinction is correct, then that is something we can
explain in the docs. However, it is still not very intuitive. Someone
looking at "Run" and "Deploy" is not automatically going to understand
the difference (for most people, these two verbs are synonyms).
Comment 5 Martin Adamek 2005-03-02 12:04:23 UTC
But Pavel was speaking about web project. For EJB there is no
difference between Run and Deploy.
Comment 6 jrojcek 2005-03-02 12:39:40 UTC
Okay, I will put here my perspective on how those actions work (should work?) for all 
project types:

Web Run - does "incremental" deploy and opens the main web page in a browser
Web Deploy - does undeploy then deploy and doesn't open any web page in a browser

EJB Run - does "incremental" deploy
EJB Deploy - does undeploy then deploy

EntApp Run - does "incremental" deploy and opens the main web page in a browser
EntApp Run - does undeploy then deploy and doesn't open any web page in a browser

Is this how it works? If not, somebody please summarize the actual behavior of Run/
Deploy for all projects.
Comment 7 Petr Jiricka 2005-03-02 13:48:55 UTC
Jano - did you mean this?

EntApp Deploy - does undeploy then deploy and doesn't open any web
page in a browser

Web and EJB project do not follow the UI spec (they have "Redeploy"),
assigning to Andrei.
Comment 8 jrojcek 2005-03-02 13:56:51 UTC
Yes, I meant "EntApp Deploy" as the last item.
Comment 9 Andrei Badea 2005-03-02 20:16:10 UTC
The web and EJB project don't follow the UI spec because Pavel Buzek
said it should be Redeploy. Assigning to him.

BTW I don't think "Run" is a good name for "incremental deploy". We
probably shouldn't have "Run" in the EJB project at all, because this
action doesn't "run" anything, it merely deploys the EJB module to the
server. I understand we want to be coherent (since we have "Run" in
the web project). But should we give an action a rather undescriptive
name just to be coherent?

IMO in the EJB project we should have: 
- "Deploy" (for the incremental deployment, if it works) with shortcut F6
- "Redeploy"
Comment 10 Geertjan Wielenga 2005-03-03 06:52:30 UTC
I think in the web project we could have the same, i.e., "Deploy" and
"Redeploy" instead of "Run" and "Redeploy". But I'm not sure what
should happen if a project hasn't been deployed yet. If it hasn't been
deployed yet, maybe the "Redeploy" should be disabled? Of course, I
don't know about all the reasoning that are behind these decisions, so
this is just an uninformed opinion.
Comment 11 Libor Kotouc 2005-03-03 09:15:32 UTC
FYI, WSAD5.1 has only 'Run on server' and 'Debug on server' choices
and is satisfied with this. From my own experience it is enough for a
user.

Maybe we should shift to higher level of abstraction. The user usually
wants to _run_ (or debug) his module without differing between
deploy-run and deploy/redeploy.
He simply wants to see the result and he is not interested in details
like incremental deploy.

With Deploy operation we has to solve to problem with EJB module -
does a user want to run server in debug mode or not?
Comment 12 Geertjan Wielenga 2005-03-03 09:19:58 UTC
Yes, but my understanding of the difference between 'Run' and 'Deploy'
is that one is FASTER than the other. One is incremental and the other
undeploys everything and then redeploys everything. So maybe the menu
items should reflect this distinction somehow (e.g., "Quick Deploy"
and "Complete Deploy").
Comment 13 jrojcek 2005-03-03 10:43:30 UTC
We have to stick with Run, because there is "Run Main Project" menu item and "Run" is the 
contextual alternative of that action. We can maybe call it "Undeploy and Run" or 
"Undeploy then Run" or something like that, which looks a bit weird.
Comment 14 Pavel Buzek 2005-03-17 05:09:13 UTC
If I understand correctly the conclusion is that I will rename the menu item on
web application project from Redeploy to Deploy. This action will undeploy the
web module if previously deployed and then deploy it. I will also make sure that
this action does NOT bring up the browser, which is filed as 51599.
This can be easilly fixed in 4.1.
Comment 15 _ ludo 2005-03-17 05:18:30 UTC
doing a real undeploy, then a deploy make sense, so yes...
Are we doing the same on ejbmodule and j2ee apps? I am not so sure anymore...
Comment 16 Pavel Buzek 2005-03-17 05:51:05 UTC
I checked in the source of ear and ejbjar projects and yes, we are doing
undeploy/deploy on the deploy action. This is what Jano recommended here.
(it is _not_ what is in UI spec, btw)
Comment 17 Pavel Buzek 2005-03-17 06:00:57 UTC
I checked in the source of ear and ejbjar projects and yes, we are doing
undeploy/deploy on the deploy action. This is what Jano recommended here.
(it is _not_ what is in UI spec, btw)
Comment 18 Pavel Buzek 2005-03-17 14:56:02 UTC
fixed in web/project, ear, ejbproject:

cvs commit -m "55312 Deploy/Redeploy action"
src\org\netbeans\modules\web\project\ui\Bundle.properties (in directory
C:\nb_all\web\project\)
Checking in src/org/netbeans/modules/web/project/ui/Bundle.properties;
/cvs/web/project/src/org/netbeans/modules/web/project/ui/Bundle.properties,v 
<--  Bundle.properties
new revision: 1.32; previous revision: 1.31
done

cvs commit -m "56522 Clean&Build\n55312 Deploy/Redeploy action"
ejbjarproject\src\org\netbeans\modules\j2ee\ejbjarproject\ui\Bundle.properties
utilities\src\org\netbeans\modules\j2ee\common\ui\Bundle.properties (in
directory C:\nb_all\j2ee\)
Checking in
ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/Bundle.properties;
/cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.10; previous revision: 1.9
done
Checking in utilities/src/org/netbeans/modules/j2ee/common/ui/Bundle.properties;
/cvs/j2ee/utilities/src/org/netbeans/modules/j2ee/common/ui/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.6; previous revision: 1.5
done
Comment 19 zikmund 2005-07-13 16:23:55 UTC
Verified.