This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 53233 - No end tags are offered.
Summary: No end tags are offered.
Status: CLOSED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Editor (show other bugs)
Version: 4.x
Hardware: PC Windows XP
: P2 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords: REGRESSION
: 54247 (view as bug list)
Depends on: 54404
Blocks:
  Show dependency tree
 
Reported: 2005-01-11 14:39 UTC by Jiri Kovalsky
Modified: 2009-05-18 10:45 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
NPE in RequestProcessor when end tags should be offered. (823 bytes, text/plain)
2005-02-03 15:36 UTC, Jiri Kovalsky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2005-01-11 14:39:35 UTC
Continuous development build #050110 of NetBeans 4.1
Windows XP, JDK 1.5 build #64

Description:
============
User has to type all end tags manually since code
completion fails to work completely in this
situation. This is serious regression against
NetBeans 4.0.

Steps to reproduce:
===================
1. Create new project and new HTML file from
template inside.
2. Type "</" at line 8 and press CTRL+Space.
3. Simply put nothing happens.
Comment 1 Petr Pisl 2005-01-11 17:45:01 UTC
I notice this as well.

When I had page with code:
<f:view>
      <h1>This is my first JSF application from scratch.</|
</f:view>

adn ivoke the CC on the position which is represented with the char
'|' the cc entered f:view> as closing tag, not h1>
Comment 2 Marek Fukala 2005-01-11 18:03:23 UTC
the problem arises from HTML syntax changes. Will be fixed in 4.1.
Comment 3 zikmund 2005-02-01 07:51:52 UTC
*** Issue 54247 has been marked as a duplicate of this issue. ***
Comment 4 Jaroslav Tulach 2005-02-01 08:58:38 UTC
I'd like a test be written to prevent such basic regressions from
happening in future.
Comment 5 Petr Pisl 2005-02-02 16:56:51 UTC
The HTMLSyntaxSupport has to be rewrited. The getElementChaing and
getNextElement don't know anything about the new tokens, which were
introduce by Marek,  and don't work properly.
Comment 6 Jaroslav Tulach 2005-02-03 07:50:16 UTC
Tests need to be written to make sure commits like this will not
happen in future.
Comment 7 Marek Fukala 2005-02-03 10:53:06 UTC
fixed in trunk.

Checking in HTMLCompletionQuery.java;
/cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v
 <--  HTMLCompletionQuery.java
new revision: 1.5; previous revision: 1.4
done
Checking in HTMLSyntaxSupport.java;
/cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLSyntaxSupport.java,v
 <--  HTMLSyntaxSupport.java
new revision: 1.4; previous revision: 1.3
done
Comment 8 Jiri Kovalsky 2005-02-03 15:35:21 UTC
I am sorry but I have to reopen this issue. Now there is always NPE
thrown everytime one types </ and waits for code completion.

Steps to reproduce:
===================
1. Create new sample web application project.
2. Type </ at line 21 of index.jsp and wait for code completion.
3. NPE will be thrown.
Comment 9 Jiri Kovalsky 2005-02-03 15:36:32 UTC
Created attachment 20177 [details]
NPE in RequestProcessor when end tags should be offered.
Comment 10 Marek Fukala 2005-02-03 16:13:40 UTC
The issue you described is caused by another problem - see Issue
#54404. Petr Pisl has already fixed it in trunk and he will integrate
it is qbuild branch as well.
Comment 11 Jiri Kovalsky 2005-02-03 16:46:43 UTC
Okay, I am sorry then. Verified in continuous development build
#20050203-1408 of NetBeans 4.1. Please integrate the fix into
QBE200502012121 branch.
Comment 12 Marek Fukala 2005-02-03 17:52:12 UTC
fixed in QBE200502012121 as well.

Checking in HTMLCompletionQuery.java;
/cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v
 <--  HTMLCompletionQuery.java
new revision: 1.4.4.1; previous revision: 1.4
done
Checking in HTMLSyntaxSupport.java;
/cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLSyntaxSupport.java,v
 <--  HTMLSyntaxSupport.java
new revision: 1.3.4.1; previous revision: 1.3
done