Bug 49490 - improve validation in the deploy process
improve validation in the deploy process
Status: NEW
Product: serverplugins
Classification: Unclassified
Component: Infrastructure
4.x
All All
: P4 (vote)
: TBD
Assigned To: Pavel Buzek
issues@serverplugins
:
: 52629 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-09-23 16:28 UTC by Jan Horvath
Modified: 2009-02-13 19:53 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Horvath 2004-09-23 16:28:56 UTC
build 040923

steps to reproduce: 
-open ejb-jar.xml
-add <session> tag with duplicate name
Comment 1 _ ludo 2004-09-23 16:35:24 UTC
what is the behaviour in web area when in web.xml the user add a
duplicate entry for a servlet?
We need the same consistent behaviour in ejbs.
Comment 2 _ ludo 2004-09-24 01:49:48 UTC
hand editing ejb-jar.xml is always possible.
I did try a duplicate servlet entry in web.xml and could save the file.
As xml validation (manual step, the error agaisnt the schema was detected)

Exactely the same behaviour is happening for ejb-jar: I can save the file.

If I invoke the xml validation, I have:
Checking file:/C:/LudoApplication/Module6Ejb/src/conf/ejb-jar.xml...
Referenced entity at
"file:///C:/Sun/AppServer810/lib/schemas/j2ee_1_4.xsd".
Duplicate key value [Test] declared for identity constraint of element
"ejb-jar". [16] 


So I don't understand why this bug is filed... A user can for example
enterely corrupt a java file and still save this file.

Or what is the equivalent bug number in Web Apps?

Comment 3 Jan Horvath 2004-09-24 13:30:30 UTC
When I duplicate session bean, it adds duplicate entry in project tab,
and when I try to deploy project i fails without any reason. Only
"Deployment failed" appears.
At least there should be provided xml validation while deploying a
project.
Comment 4 _ ludo 2004-09-25 02:25:21 UTC
I see and agree
Comment 5 Petr Blaha 2004-10-13 10:45:50 UTC
Move issues from temprorary component.
Comment 6 Chris Webster 2004-12-17 18:50:34 UTC
This is related to the validation which should occur after compilation
and before / during deployment. I am changing to appserver category as
this should be done as part of the deployment cycle. 
Comment 7 Vince Kraemer 2005-02-07 17:39:30 UTC
We may be able to user the xmlvalidate task to catch this before we
send the jar off to the server.
Comment 8 Vince Kraemer 2005-02-07 18:40:46 UTC
*** Issue 52629 has been marked as a duplicate of this issue. ***
Comment 9 _ ludo 2005-03-17 06:03:10 UTC
moving to j2eeserver, as validation of j2ee dd or schemas should be done
regardless of the app server target before calling a real deployment task.
This way, jboss, oracle, bea etc would benefit from this validation step,
Comment 10 Pavel Buzek 2005-03-19 18:33:46 UTC
I still do not see this as a bug. You cannot corrupt the deployment descriptor
in this way from UI (like wizard or visual editor of ejb-jar.xml), only from
text editor, correct?

Validation cannot be added generally, tomcat's context.xml does not have a DTD
so validation fails for it. We have already integrated verifier which catches
this problem. User can run this (verifier or xml validate) manually. If we add
xml validation (and maybe verifier) as build steps they should be made optional,
just like the JSP compilation is. Note that JSP compiation is actually OFF by
default. Adding these options will require UI changes.

Comment 11 Petr Blaha 2006-03-13 13:51:05 UTC
TM 5.0 -> TBD
Comment 12 Vince Kraemer 2009-02-13 19:53:24 UTC
Based on Pavel's feedback, the validation can only apply to the 'standard dd files'

Since DD files are less relevant... this issue has a lower priority


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo