This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 48548 - First opening java file is slower - regression (200409051800 - 200409022120)
Summary: First opening java file is slower - regression (200409051800 - 200409022120)
Status: CLOSED WONTFIX
Alias: None
Product: ide
Classification: Unclassified
Component: Performance (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@performance
URL:
Keywords: PERFORMANCE, REGRESSION
Depends on:
Blocks:
 
Reported: 2004-09-06 16:03 UTC by Marian Mirilovic
Modified: 2011-05-25 11:36 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
changelog (23.78 KB, text/plain)
2004-09-15 08:04 UTC, _ rkubacki
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Mirilovic 2004-09-06 16:03:21 UTC
[jdk1.5.0](rc)

our performance tests show regression in first
opening java file between buids (200409051800 -
200409022120) :

test :    Open Java file (20kB)
(RH Linux 9  JDS 2  Solaris 9  Win 2000  Win XP)


*200409051800*
1st usage 6205 6630 8352 5036 5922
2nd usage 526 520 661 395 499

*200409022120*
1st usage 3037 3058 2469 1599 1911
2nd usage 534 523 641 393 503

*200409011800*
1st usage 2452 3049 2304 1651 1984
2nd usage 543 513 668 378 478


Numbers above show 2-3 times slower open java file
in last dev build against previous one.
Comment 1 Tomas Hurka 2004-09-06 17:28:20 UTC
Probably caused by :

  Modified:    src/org/netbeans/modules/java JavaEditor.java
                        JavaDataObject.java
  Log:
  Parsing support initialized when JavaEditor is opened

  Revision  Changes    Path
  1.175     +6 -0      java/src/org/netbeans/modules/java/JavaEditor.java

Comment 2 Tomas Hurka 2004-09-07 10:20:23 UTC
Pavel will try to reproduce it.
Comment 3 Pavel Flaska 2004-09-07 15:57:35 UTC
Hopefully fixed. Tested on my machine and seems it works correctly now.

Checking in org/netbeans/modules/java/JavaNode.java;
/cvs/java/src/org/netbeans/modules/java/JavaNode.java,v  <-- 
JavaNode.java
new revision: 1.118; previous revision: 1.117
done
Comment 4 Marian Mirilovic 2004-09-08 07:18:53 UTC
Thanks Pavel, it's much better now:

*200409071800*
1st usage 	4025 	3205 	3006 	1505 	2489
2nd usage 	475 	498 	657 	393 	490


but there is still regression 

Lin 30%, JDS 8%, Sol 5%, Win2K -1%, WinXP 25%

wait for tomorrow results, if regression still measured I'll file new
issue.

significant improvement - verified
Comment 5 Antonin Nebuzelsky 2004-09-08 10:31:22 UTC
Keeping opened until we verify by the test results that this is not
regression. Until then, this is considered as beta-2 showstopper.
Comment 6 Marian Mirilovic 2004-09-09 13:31:22 UTC
Today's numbers show still existing regression (or/and variation of
measured values grows):

*200409081800*
1st usage 	3509 	3286 	4184 	1510 	2739
2nd usage 	488 	503 	660 	404 	468

Comment 7 Antonin Nebuzelsky 2004-09-10 15:34:10 UTC
When fixed it will have to be merged to release40_beta2 branch.
Comment 8 Pavel Flaska 2004-09-14 15:21:56 UTC
We tried to investigate it again with Radim and we did not find
anything in Java module, which should cause this regression. Radim
pointed out one thing, which can cause the problem: There was running
full gc() during open file.
I made a small test to ensure that there is a different count of gc()
in builds. My testcase:
1. Start ide,
2. open form project,
3. find GandalfPersistenceManager in explorer,
4. use jstat to get the count of FGC, (thanks Radim for info about
jstat utility)
5. open GandalfPersistenceManager,
6. get the count of FGC again.

nb200409022120 - FGC before: 15; FGC after: 15
nb200409051800 - FGC before: 14; FGC after: 15

So seems to me that in newer build, anybody save some memory and one
full gc() was done during opening file instead of before.
(Not sure, how data is exactly purged in perf tests.)
Closing as INVALID because I suppose data is not purged. Reopen, if my
explanation is not applicable to perf test.
 
Comment 9 Pavel Flaska 2004-09-14 15:36:23 UTC
As Marian mentioned, there was done fix before reopening this bug, so
it should be marked as fixed.
Comment 10 Pavel Flaska 2004-09-14 15:37:28 UTC
Fixed on 2004-09-07.
Comment 11 Marian Mirilovic 2004-09-14 15:39:31 UTC
Thanks,
verified on 2004-09-09 .

There is still a regression, but we don't know how to fix it so verified.
Comment 12 _ rkubacki 2004-09-15 08:04:45 UTC
Created attachment 17637 [details]
changelog
Comment 13 Jan Chalupa 2004-09-15 08:33:41 UTC
Reopening as P2.

I don't think it's ok to say "there used to be no FGC, now there's
one, so it must take longer". The regression is real and it needs to
be investigated. I'm not saying that this is a java module issue, but
with the full list of changes at hand, we should be able to identify
the one that triggerred this.
Comment 14 Jan Becicka 2004-09-16 09:05:43 UTC
Performance guys, please evaluate.
Performance bug is, that we saved 1 FGC on startup, which is now
postponed to first opening of java file.
Comment 15 Pavel Flaska 2004-09-22 10:29:49 UTC
First of all, tests should be improve to show real regressions.
Comment 16 Antonin Nebuzelsky 2005-08-30 12:32:30 UTC
Old issue. File opening will be filed as new issues for promo-F as appropriate.
Comment 17 Marian Mirilovic 2005-09-07 14:00:39 UTC
v/c