This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 46608 - Order of items in freeform prj. type context menu wrong
Summary: Order of items in freeform prj. type context menu wrong
Status: CLOSED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Ant (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on:
Blocks: 42682
  Show dependency tree
 
Reported: 2004-07-27 13:19 UTC by Milan Kubec
Modified: 2006-03-24 10:05 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Kubec 2004-07-27 13:19:51 UTC 
Spec says following order:

New                        >
----------------------------
Build Project
Clean & Build Project
Clean Project
Generate Javadoc for Project
Redeploy Project
----------------------------
Run Project
Debug Project
Test Project 
----------------------------
...

But in fact it is:

----------------------------
Build Project
Clean Project
Clean & Build Project
Run Project
Generate Javadoc for Project
Test Project
----------------------------
Comment 1 Jesse Glick 2004-07-27 14:38:08 UTC 
The exact context menu of a freeform project is determined by
project.xml and the GUI customizer, so anything in the spec which says
exactly what the context menu should look like cannot be useful. (More
accurately: the central portion of the context menu is freely
editable; the top and bottom are fixed.)

However if the spec requests context menu items for targets to be
added in a particular relative order by the initial wizard (remember
that some or all of the suggested targets may not be there if they
have no mapping, and other arbitrary targets may be there) then the
wizard should be changed.
Comment 2 Milan Kubec 2004-07-27 14:50:12 UTC 
I know that available actions for menu are given by the actual script,
but Build and Clean targets will be in 99% of scripts and those could
possibly have the same order as regular J2SE Project, at least.
Comment 3 jrojcek 2004-07-27 16:32:20 UTC 
What is the problem with the spec? The order in contextual menu reflects the order of 
targets in the wizard and project properties. It is also consistent with other project types. I 
guess from UI point of view it is okay.

In "Build and Run" project properties we have two different sections - the predefined 
targets and custom targets. The contextual menu reflects that.
Comment 4 jrojcek 2004-07-27 18:31:47 UTC 
Reassign back if you disagree.
Comment 5 Jesse Glick 2004-07-27 19:54:19 UTC 
OK, will change that order accordingly.

Note that the freeform project type does not yet support separators
between custom menu items, but I will add a note to that effect.

Also trying to correct some apparent mistakes in the existing
customizer form: (1) 'test' should always be shown, even in web app
projects; (2) Redeploy was displayed below Test whereas the spec has
it above.
Comment 6 Jesse Glick 2004-07-28 22:00:49 UTC 
Restoring the customizer form to a normal appearance after those
(seemingly trivial) changes was quite a task... the joys of
dynamically modified layouts.
Comment 7 Jesse Glick 2004-07-28 22:06:43 UTC 
committed   * Up-To-Date  1.2         ant/freeform/build.xml
committed   * Up-To-Date  1.11       
ant/freeform/src/org/netbeans/modules/ant/freeform/ui/TargetMappingPanel.form
committed   * Up-To-Date  1.18       
ant/freeform/src/org/netbeans/modules/ant/freeform/ui/TargetMappingPanel.java
Comment 8 Milan Kubec 2004-07-29 11:18:59 UTC 
Verified in custom 20040729.