This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 44522 - No VCS actions and states in Projects/Files explorer - masterfs does not call provider
Summary: No VCS actions and states in Projects/Files explorer - masterfs does not call...
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Filesystems (show other bugs)
Version: 4.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: rmatous
URL:
Keywords: REGRESSION
: 44567 44655 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-06-08 13:18 UTC by Milos Kleint
Modified: 2008-12-22 17:38 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Milos Kleint 2004-06-08 13:18:26 UTC
in yestarday's buld (20040608) i don't have any
cvs actions or states visible in Projects and
Files tabs. The vcs filesystem root is also not
visible in Favourites tab.
Only way to invoke vcs action is thought the vcs
explorer tab.

I haven't tried with a clean usedir.
Comment 1 Martin Entlicher 2004-06-09 09:33:35 UTC
*** Issue 44567 has been marked as a duplicate of this issue. ***
Comment 2 Martin Entlicher 2004-06-09 09:34:53 UTC
I don't remember to do any changes that could cause this recently.
I'll try to find out what's wrong...
Comment 3 Martin Entlicher 2004-06-09 10:02:23 UTC
It was caused by the changes in masterfs module. After I updated
following files, this bug has occured. I'll check the code to see
whether I do not call something in a bad way.

The changes are:

Index: masterfs/Delegate.java
===================================================================
RCS file:
/cvs/openide/masterfs/src/org/netbeans/modules/masterfs/Delegate.java,v
retrieving revision 1.10
retrieving revision 1.9
diff -c -r1.10 -r1.9

Index: masterfs/InvalidDummy.java
===================================================================
RCS file:
/cvs/openide/masterfs/src/org/netbeans/modules/masterfs/InvalidDummy.java,v
retrieving revision 1.6
retrieving revision 1.5
diff -c -r1.6 -r1.5

Index: masterfs/MasterFileObject.java
===================================================================
RCS file:
/cvs/openide/masterfs/src/org/netbeans/modules/masterfs/MasterFileObject.java,v
retrieving revision 1.23
retrieving revision 1.22
diff -c -r1.23 -r1.22

Index: masterfs/MountTable.java
===================================================================
RCS file:
/cvs/openide/masterfs/src/org/netbeans/modules/masterfs/MountTable.java,v
retrieving revision 1.13
retrieving revision 1.11
diff -c -r1.13 -r1.11

The changes in InvalidDummy.java and MasterFileObject.java are trivial
and did not change the behavior.
Comment 4 Martin Entlicher 2004-06-09 10:33:53 UTC
The regression seems to be caused by the fact that
ProviderCall.isMountAble() is not called any more. The ProviderCall
looked for all FS providers and initialized them.
After this change, VcsFSProvider is not called any more.
Comment 5 Jesse Glick 2004-06-09 13:08:44 UTC
Surely masterfs has unit tests to make sure this sort of thing doesn't
happen...?
Comment 6 rmatous 2004-06-09 15:33:25 UTC
Fixed +  added test (till now just methods MountTable.mount and
unmount were tested).  

/cvs/openide/masterfs/src/org/netbeans/modules/masterfs/MasterFileSystem.java,v
 <--  MasterFileSystem.java
new revision: 1.12; previous revision: 1.11

/cvs/openide/masterfs/src/org/netbeans/modules/masterfs/ProviderCall.java,v
 <--  ProviderCall.java
new revision: 1.4; previous revision: 1.3

/cvs/openide/masterfs/test/unit/src/org/netbeans/modules/masterfs/MasterFileObjectTestHid.java,v
 <--  MasterFileObjectTestHid.java
new revision: 1.9; previous revision: 1.8

/cvs/openide/masterfs/test/unit/src/org/netbeans/modules/masterfs/MasterFileSystemTest.java,v
 <--  MasterFileSystemTest.java
new revision: 1.6; previous revision: 1.5
Comment 7 Martin Entlicher 2004-06-10 09:40:00 UTC
*** Issue 44655 has been marked as a duplicate of this issue. ***
Comment 8 Marian Mirilovic 2005-12-16 16:30:45 UTC
verify/close