This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 43663 - Another NPE when navigating in Open Project dialog (fix attached)
Summary: Another NPE when navigating in Open Project dialog (fix attached)
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Infrastructure (show other bugs)
Version: 4.x
Hardware: Macintosh Mac OS X
: P2 blocker (vote)
Assignee: Petr Hrebejk
URL:
Keywords:
Depends on:
Blocks: 41535
  Show dependency tree
 
Reported: 2004-05-21 12:05 UTC by _ tboudreau
Modified: 2004-08-13 12:11 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2004-05-21 12:05:55 UTC
Once again it is impossible to open projects on mac.  You are 
missing a null check - line 172 of ProjectChooserAccessory is

File dir = rawdir != null ? FileUtil.normalizeFile(rawdir) : null;

but the result is passed to convertToValidDir() at line 215, and 
convertToValidDir() does not check for null.  Suggest changing 
line 221 to:

File testFile = f == null ? null : new File( f.getPath() );
                  ^^^^^^^^^^^



Switch to root directory and double click any directory and you 
get:

java.lang.NullPointerException
	at 
org.netbeans.modules.project.ui.ProjectChooserAccessory.conve
rtToValidDir(ProjectChooserAccessory.java:220)
	at 
org.netbeans.modules.project.ui.ProjectChooserAccessory.isProj
ectDir(ProjectChooserAccessory.java:214)
	at 
org.netbeans.modules.project.ui.ProjectChooserAccessory.prope
rtyChange(ProjectChooserAccessory.java:175)
	at 
javax.swing.event.SwingPropertyChangeSupport.firePropertyCha
nge(SwingPropertyChangeSupport.java:264)
	at 
javax.swing.event.SwingPropertyChangeSupport.firePropertyCha
nge(SwingPropertyChangeSupport.java:232)
	at 
javax.swing.JComponent.firePropertyChange(JComponent.java:
3819)
	at 
javax.swing.JFileChooser.setSelectedFile(JFileChooser.java:454)
	at 
apple.laf.AquaFileChooserUI$SelectionListener.valueChanged(Aq
uaFileChooserUI.java:601)
	at 
javax.swing.DefaultListSelectionModel.fireValueChanged(Default
ListSelectionModel.java:187)
	at 
javax.swing.DefaultListSelectionModel.fireValueChanged(Default
ListSelectionModel.java:167)
	at 
javax.swing.DefaultListSelectionModel.fireValueChanged(Default
ListSelectionModel.java:214)
	at 
javax.swing.DefaultListSelectionModel.changeSelection(DefaultLi
stSelectionModel.java:402)
	at 
javax.swing.DefaultListSelectionModel.changeSelection(DefaultLi
stSelectionModel.java:411)
	at 
javax.swing.DefaultListSelectionModel.removeSelectionInterval(D
efaultListSelectionModel.java:481)
	at 
javax.swing.DefaultListSelectionModel.clearSelection(DefaultListS
electionModel.java:416)
	at javax.swing.JTable.clearSelection(JTable.java:1262)
	at 
apple.laf.AquaFileChooserUI.openDirectory(AquaFileChooserUI.ja
va:636)
	at 
apple.laf.AquaFileChooserUI$DoubleClickListener.mouseClicked(
AquaFileChooserUI.java:658)
	at 
java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaste
r.java:212)
	at 
java.awt.Component.processMouseEvent(Component.java:5103)
	at java.awt.Component.processEvent(Component.java:
4897)
	at java.awt.Container.processEvent(Container.java:1569)
	at java.awt.Component.dispatchEventImpl(Component.java:
3615)
	at java.awt.Container.dispatchEventImpl(Container.java:
1627)
	at java.awt.Component.dispatchEvent(Component.java:
3477)
	at 
java.awt.LightweightDispatcher.retargetMouseEvent(Container.ja
va:3483)
	at 
java.awt.LightweightDispatcher.processMouseEvent(Container.ja
va:3207)
	at 
java.awt.LightweightDispatcher.dispatchEvent(Container.java:
3128)
	at java.awt.Container.dispatchEventImpl(Container.java:
1613)
	at java.awt.Window.dispatchEventImpl(Window.java:1606)
	at java.awt.Component.dispatchEvent(Component.java:
3477)
[catch] at java.awt.EventQueue.dispatchEvent(EventQueue.java:
479)
	at 
java.awt.EventDispatchThread.pumpOneEventForHierarchy(Event
DispatchThread.java:234)
	at 
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDis
patchThread.java:184)
	at 
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDis
patchThread.java:174)
	at java.awt.Dialog$1.run(Dialog.java:540)
	at java.awt.Dialog.show(Dialog.java:561)
	at javax.swing.JFileChooser.showDialog(JFileChooser.java:
696)
	at 
javax.swing.JFileChooser.showOpenDialog(JFileChooser.java:599)
	at 
org.netbeans.modules.project.ui.actions.OpenProject.actionPerfo
rmed(OpenProject.java:54)
	at 
javax.swing.AbstractButton.fireActionPerformed(AbstractButton.j
ava:1819)
	at 
javax.swing.AbstractButton$ForwardActionEvents.actionPerform
ed(AbstractButton.java:1872)
	at 
javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButt
onModel.java:420)
	at 
javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.
java:258)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:
321)
	at 
javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemU
I.java:1113)
	at 
javax.swing.plaf.basic.BasicMenuItemUI$MouseInputHandler.mo
useReleased(BasicMenuItemUI.java:943)
	at 
java.awt.Component.processMouseEvent(Component.java:5100)
	at java.awt.Component.processEvent(Component.java:
4897)
	at java.awt.Container.processEvent(Container.java:1569)
	at java.awt.Component.dispatchEventImpl(Component.java:
3615)
	at java.awt.Container.dispatchEventImpl(Container.java:
1627)
	at java.awt.Component.dispatchEvent(Component.java:
3477)
	at 
java.awt.LightweightDispatcher.retargetMouseEvent(Container.ja
va:3483)
	at 
java.awt.LightweightDispatcher.processMouseEvent(Container.ja
va:3198)
	at 
java.awt.LightweightDispatcher.dispatchEvent(Container.java:
3128)
	at java.awt.Container.dispatchEventImpl(Container.java:
1613)
	at java.awt.Window.dispatchEventImpl(Window.java:1606)
	at java.awt.Component.dispatchEvent(Component.java:
3477)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:
479)
	at 
java.awt.EventDispatchThread.pumpOneEventForHierarchy(Event
DispatchThread.java:234)
	at 
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDis
patchThread.java:184)
	at 
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread
.java:178)
	at 
java.awt.EventDispatchThread.pumpEvents(EventDispatchThread
.java:170)
	at 
java.awt.EventDispatchThread.run(EventDispatchThread.java:
100)
Comment 1 Jesse Glick 2004-05-21 16:29:16 UTC
Might be from Radek's recent patches? Don't know.
Comment 2 rmatous 2004-05-21 17:30:13 UTC
/cvs/java/platform/src/org/netbeans/modules/java/platform/wizard/LocationChooser.java,v
 new revision: 1.9; previous revision: 1.8

/cvs/projects/projectui/src/org/netbeans/modules/project/ui/ProjectChooserAccessory.java,v
 new revision: 1.12; previous revision: 1.11
Comment 3 Jesse Glick 2004-05-21 17:40:48 UTC
Thanks Radek!