This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 41352 - PVCS: Error in Diff
Summary: PVCS: Error in Diff
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: Sun SunOS
: P1 blocker (vote)
Assignee: Richard Gregor
URL:
Keywords:
: 41359 41363 41365 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-03-25 14:56 UTC by Peter Pis
Modified: 2004-03-31 15:02 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
diff of fix in trunk (1.23 KB, patch)
2004-03-30 12:56 UTC, Richard Gregor
Details | Diff
the same fix also in pvcs_Loc profile (704 bytes, patch)
2004-03-30 13:35 UTC, Richard Gregor
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Pis 2004-03-25 14:56:14 UTC
When Diff is invoked on some node, error will occur. 

For Example: This is the execution string of command:
vdiff
-dl
-r
"/tmp/test/testPVCS/Repo/archives/test/another/Class_B.java-arc"(/tmp/test/testPVCS/Work/test/another/Class_B.java)

After moving second quote to end of execution
string   it worked well in command line.
Comment 1 Peter Pis 2004-03-25 16:29:37 UTC
*** Issue 41365 has been marked as a duplicate of this issue. ***
Comment 2 Martin Entlicher 2004-03-26 09:11:36 UTC
This approach works on Windows systems, but apparently not on UNIX.
The execution of this command was changed recently and it looks like
there is some strange problem with quotation. I will check this as
soon as I get an access to a Solaris system with PVCS.

It probably does not have sense to have separate issues #41363 and
#41359. After this issue will be solved, the same fix will be applied
to fix those issues.

Also, why there are different priorities, when the problem is exactly
the same?
Comment 3 Tomas Pavek 2004-03-26 09:52:28 UTC
*** Issue 41359 has been marked as a duplicate of this issue. ***
Comment 4 Tomas Pavek 2004-03-26 09:52:45 UTC
*** Issue 41363 has been marked as a duplicate of this issue. ***
Comment 5 Richard Gregor 2004-03-30 12:52:43 UTC
Fixed in trunk.

Checking in pvcs.xml;

/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcs.xml,v
 <--  pvcs.xml

new revision: 1.13; previous revision: 1.12

done
Comment 6 Richard Gregor 2004-03-30 12:56:08 UTC
Created attachment 14201 [details]
diff of fix in trunk
Comment 7 Martin Entlicher 2004-03-30 13:05:08 UTC
Fix reviewed without objections.
Comment 8 Richard Gregor 2004-03-30 13:35:09 UTC
Created attachment 14202 [details]
the same fix also in pvcs_Loc profile
Comment 9 Richard Gregor 2004-03-30 13:37:40 UTC
Fixed also in pvcsLoc profile in trunk

Checking in pvcsLoc_XX.xml;

/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsLoc_XX.xml,v
 <--  pvcsLoc_XX.xml

new revision: 1.13; previous revision: 1.12

done
Comment 10 Peter Pis 2004-03-30 16:48:52 UTC
Verified on RC1 with the use of pvcs.xml
Comment 11 Richard Gregor 2004-03-30 16:58:20 UTC
Thanks for review and verification.
Comment 12 Richard Gregor 2004-03-31 15:02:32 UTC
Fix merged to release36.

Checking in pvcs.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcs.xml,v
 <--  pvcs.xml
new revision: 1.10.2.2; previous revision: 1.10.2.1
done
Checking in pvcsLoc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsLoc_XX.xml,v
 <--  pvcsLoc_XX.xml
new revision: 1.10.2.2; previous revision: 1.10.2.1
done