This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I updated the Help menu to get rid of bookmarks, which I doubt are often used. However, it looks like the commit validation suite assumes that bookmarks will be installed, so the commit validation fails, even though the Help menu works as desired.
Jirka, in case you didn't see this. I think it was my removal of the bookmarks in the Help menu that breaks the commit validation.
Actually, tests are under core module. Jarda or someone else should fix it.
I just spoke with Marian, who said he suspects that something in the tests is probably trying to place something in the Bookmarks folder. This made me realize that maybe I should add a file attribute to the layer file, so what used to be: <folder name="Menu"> <folder name="Help"> <folder name="Bookmarks"> <attr name="SystemFileSystem.localizingBundle" stringvalue="org.netbeans.modules.url.Bundle"/> </folder> </folder> </folder> would now be <folder name="Menu"> <folder name="Help"> <attr name="Bookmarks\SystemFileSystem.localizingBundle" stringvalue="org.netbeans.modules.url.Bundle"/> </folder> </folder> <folder name="Help"> <attr name="HelpShortcuts\SystemFileSystem.localizingBundle" stringvalue="xxx"/> </folder> If I understand the layering mechanism correctly, this fix would allow people to install into the Bookmarks folder, but not display the Bookmarks folder if there are no bookmarks installed. It's not my favorite solution, since I would have to find a place for the Bookmarks that would not destroy the symmetry of the reconfigured Help menu should somebody install one. I also agree with the comment (Jesse's?) in the layer file that says we should get rid of BookmarkAction entirely (and just let people install things straight to the Help menu).
Just a general comment. In the latest build there is a malformed "IDE Configuration -> System -> org-netbeans-modules-url-BookmarksNode" node. I don't know who should fix it but it has to be fixed as well.
probably no need to fix the commit validation, since Jesse has identified other things that could be fixed without breaking commit validation. Marking as duplicate to the issue Jesse filed *** This issue has been marked as a duplicate of 40397 ***
There is nothing wrong with the test suite whatsoever. It correctly identified a bug that was introduced in the code. The broken node in the Options dialog is a visible symptom of the bug that the test caught. BTW <folder name="Menu"> <folder name="Help"> <attr name="Bookmarks\SystemFileSystem.localizingBundle" stringvalue="org.netbeans.modules.url.Bundle"/> </folder> </folder> makes no sense since there was never such a folder as Menu/Help/Bookmarks/ (it was Bookmarks/ and a special action in Menu/Help/ displayed its contents). If you don't want the Bookmarks node functionality to appear in the IDE, then probably best to just delete every remnant of it. (And add a note to the Upgrade Guide that the folder is gone and there is no purpose in adding anything new to it - just add *.url files directly to Menu/Help/ or subfolders thereof as needed.)