This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
See test logs at marked URL. Caused by recent commits from pkeegan. Services/org-netbeans-modules-url-BookmarksNode.instance and UI/Services/IDEConfiguration/System/org-netbeans-modules-url-BookmarksNode.shadow cannot exist so long as the Bookmarks/ folder does not exist (you commented it out). Actions/Help/org-netbeans-modules-url-BookmarksAction.instance does not make any sense either so long as this folder does not exist - it will not throw exceptions if you add it to e.g. a menu, but it will not display anything either. Please either 1. Reinstate the Bookmarks/ folder, possibly empty, so that it can be used. (A user would have to manually copy BookmarksAction to some menu folder in order to see the bookmarks, however.) or 2. Remove the three obsolete files mentioned above from the layer (and if the removal is to be permanent consider deleting the corresponding Java sources as well: BookmarksAction.java and BookmarksNode.java). Note: you also get java.lang.IllegalArgumentException: Called DataObject.find on null at org.openide.loaders.DataObject.find(DataObject.java:435) at org.openide.loaders.DataFolder.findFolder(DataFolder.java:518) at org.netbeans.modules.url.BookmarksNode.<init>(BookmarksNode.java:70) on console when opening the System folder in the Options dialog, for the same reason the test is broken.
*** Issue 40358 has been marked as a duplicate of this issue. ***
Created attachment 13594 [details] quick fix for bookmark problem
I attached a proposed patch. However, sanity checking the fix by building the module, adding it to an an existing build, and trying copy a bookmark instance from actions to the menu threw a missing resource, so I would only commit it in conjunction with adding these two keys to the bundle file: Templates/Other/bookmark.url=Web Bookmark Bookmarks=&Bookmarks Jesse, if you sanity check the patch, I'll apply it within the half hour. BTW, I prefer the second option that you listed, but for some reason I couldn't get it to work properly at the moment, but that's what I'll probably ask Marian to do permanently
No idea what you are talking about w.r.t. the bundle key for Templates/Other/bookmark.url; this file is unrelated to the Bookmarks/ folder, was not deleted, and still has a bundle key in .../url/Bundle.properties as it should. The MRE you got is probably because you failed to comment out <attr name="SystemFileSystem.localizingBundle" stringvalue="org.netbeans.modules.url.Bundle"/> <attr name="helpID" stringvalue="org.netbeans.modules.url.BookmarksNode"/>
RE: Templates/Other/bookmark.url; Yep, I misread my diff. RE the uncommented out attributes, I assumed that they would have to stay around for the folder to mean anything
But the folder *doesn't* mean anything any more.
*** Issue 40371 has been marked as a duplicate of this issue. ***
*** Issue 40405 has been marked as a duplicate of this issue. ***
fixed by commenting out the relevant files from Layer.xml the remaining changes to be done: - delete the commented sections - delete the unused Java files
I see that the commit validation is working now. Thanks a lot for your help, Marian.
One thought: the Studio folks have been using URL files in the Filesystems window. Would the deletion of BookmarksAction.java and BookmarksNode.java prevent them from using URLs in the future?
Nope, *.url files should work fine without BookmarksAction and BookmarksNode.
Is there an issue filed for the remaining tasks like deleting BookmarksAction/Node? These are not yet done.
No, there is not. I have not evaluated yet whether it is OK to delete the files. Words like "should work fine" do not sound well to me.
Jesse, could you please verify this issue? Thanks.
Long dead.