This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 39419 - Prop. sheet buttons different from Component palette
Summary: Prop. sheet buttons different from Component palette
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Explorer (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: _ tboudreau
URL:
Keywords: UI
: 40489 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-01-30 15:39 UTC by Milan Kubec
Modified: 2008-12-22 20:00 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (12.64 KB, image/png)
2004-01-30 15:42 UTC, Milan Kubec
Details
screenshot (2.31 KB, image/png)
2004-02-23 10:50 UTC, Milan Kubec
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Kubec 2004-01-30 15:39:14 UTC
There are toggle buttons in property sheet that
are supposed to have the same functionality as
toggle buttons in Component palette. But Buttons
in prop. sheet are stretched out on whole width of
prop. sheet. Buttons in Component palette don't do
that. There should be consistency IMO. See
screenshot. I personaly like the way how prop.
sheet buttons are stretched. Also note that
buttons in prop. sheet have better (equal) spacing
around them.
Comment 1 Milan Kubec 2004-01-30 15:42:58 UTC
Created attachment 13165 [details]
screenshot
Comment 2 Lukas Hasik 2004-01-30 16:50:00 UTC
property sheet's implementation of toggle buttons should follow the
toggle buttons ui spec originally writen for pallete 

http://ui.netbeans.org/docs/ui/palette/newUI.html
Comment 3 _ tboudreau 2004-01-30 18:55:19 UTC
I've exchanged some emails about this with Dusan and am waiting for a final answer 
before I change anything.
Comment 4 dpavlica 2004-02-06 17:42:54 UTC
I talked to Tim about some inconsistency and PS implementation could
be improved in this way:
1. "Basic Properties" name of toggle button will be changed to
"Properties" name.
2. Toggle Buttons situated in one line of ToolBar should be aligned to
the left (as it exists in Comp. palette, To Do, VCS output or in the
Source Editor as "nested TABs" in the future). Toggles will be also on
one row in a case of absence necessary width for all three toggles.
Then labels inside toggles will contain "..." at the end.   
3. There is no shadow line at the right side of ToolBar (this gray
line is visible in implementation of the Component palette).

Possible improvement is about height of toggle buttons. I recommend to
make them 2 px smaller (if it's implement-able).

That equal spacing (1px) around toggles is better of course, but it
should work on all supported L&F. This spacing is different on the
Windows 2000 then on the Windows XP.

And...Let's note please, that we would like to have only one shared
component of Toolbar with toggle buttons (in openide) in the future.
So then it will be 100% consistent everywhere...Heavy borders around
Toolbar should be removed in the future too. This issue needs to be
solved in Win. System implementation.
Comment 5 _ tboudreau 2004-02-21 23:41:37 UTC
Fixed in trunk.

Checking in Bundle.properties;
/cvs/openide/src/org/openide/explorer/propertysheet/Bundle.properties,v  <--  
Bundle.properties
new revision: 1.39; previous revision: 1.38
done
Checking in SheetTabbedPane.java;
/cvs/openide/src/org/openide/explorer/propertysheet/SheetTabbedPane.java,v  <--  
SheetTabbedPane.java
new revision: 1.7; previous revision: 1.6
done
Processing log script arguments...
Mailing the commit message to cvs@openide.netbeans.org (from 
tboudreau@netbeans.org)
Comment 6 Milan Kubec 2004-02-23 10:50:15 UTC
Seems as partially fixed. The buttons are not spred out, but the look
at least "strange", see screehshot from WinXP.
Comment 7 Milan Kubec 2004-02-23 10:50:58 UTC
Created attachment 13567 [details]
screenshot
Comment 8 _ tboudreau 2004-02-23 11:40:19 UTC
Ah...the metrics are different for XP L&F.  Should be a two line change.
Comment 9 _ tboudreau 2004-02-27 14:11:04 UTC
*** Issue 40489 has been marked as a duplicate of this issue. ***
Comment 10 _ tboudreau 2004-02-29 04:00:29 UTC
Fixed in trunk.

Checking in SheetTabbedPane.java;
/cvs/openide/src/org/openide/explorer/propertysheet/SheetTabbedPane.java,v
 <--
 SheetTabbedPane.java
new revision: 1.9; previous revision: 1.8
done
Processing log script arguments...
Mailing the commit message to cvs@openide.netbeans.org (from
tboudreau@netbeans.
org)
Comment 11 _ tboudreau 2004-02-29 04:31:49 UTC
x
Comment 12 Milan Kubec 2004-03-01 15:37:16 UTC
Verified.