This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 35499 - "Find" item in disabled
Summary: "Find" item in disabled
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: Jaroslav Havlin
URL:
Keywords: REGRESSION
: 35495 35701 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-08-19 19:40 UTC by andrew
Modified: 2011-08-10 20:51 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Fix that seems to work (3.12 KB, patch)
2003-08-21 15:39 UTC, Jaroslav Tulach
Details | Diff
Actions Are disabled (53.64 KB, image/png)
2008-11-10 10:22 UTC, scanti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andrew 2003-08-19 19:40:34 UTC
Env.: j2se 1.4.2, linux 2.4.20, kde 3.1.3.
NB:  current dev. CVS trunk, starting NB with empty 
user dir.
Bug: folder context menu has "Find" item in disabled 
state.
And: not sure, against which module the issue must be 
reported
Comment 1 pzajac 2003-08-20 08:53:24 UTC
reassigned to openide/actions. The action is active but is shown as
disabled. This bug is not the only problem of Find Action.  This is
problem of  Replace Action, Undo, Redo action too. 

Comment 2 Marian Petras 2003-08-20 14:17:19 UTC
*** Issue 35495 has been marked as a duplicate of this issue. ***
Comment 3 Peter Zavadsky 2003-08-21 12:45:40 UTC
What regression? When did it happen?
Comment 4 andrew 2003-08-21 13:21:22 UTC
Unfortunately, I can not specify 
the regression date - I was
in short vacation from the 
beginning of august.
Comment 5 Peter Zavadsky 2003-08-21 13:57:11 UTC
OK, was it fine somewhen in July?

I'm just trying to ensure it was not caused by integration of issue
#27868.
Comment 6 Jesse Glick 2003-08-21 14:02:59 UTC
I have an Aug 19 dev build in which the menu item is sometimes
enabled, sometimes not, according to no apparent pattern - even
changes for the same folder when repeatedly right-clicking it. The
menu item in the Edit menu also shows the same behavior.

I have no idea what might have caused the regression - some window
system change, perhaps, or something in actions - but anyway note that
the utilities module (FindActionManager) still uses the old-style
technique of calling FindAction.setActionPerformer upon focus change,
rather than the recommended ActionMap entry in the explorer.
Comment 7 Jesse Glick 2003-08-21 14:07:17 UTC
I can reproduce in a [dev aug 11] build but not in a [dev jun 25]
build. I don't seem to have any intermediate dev builds lying around.
I also use Linux, BTW - RH Linux w/ Sawfish.
Comment 8 andrew 2003-08-21 14:16:59 UTC
During almost all july, all was fine, I think -
I use almost _everyday_ new builds in my 
(production) work :-) an am happy :-)
Comment 9 Peter Zavadsky 2003-08-21 14:35:08 UTC
I looked at it... and it seems it is caused by
change of org.openide.util.actions.CallbackSysemAction.java 1.30
..passing to Yarda

Hint:
At the line 315, there is called to clear of performers, and it is
also cleared just set performed for Find action.

Debug it the way you put a debug messages (dump stack) in
FindAction.setActionPerformer (by overriding it).
Comment 10 Jaroslav Tulach 2003-08-21 15:39:25 UTC
Created attachment 11392 [details]
Fix that seems to work
Comment 11 Jaroslav Tulach 2003-08-21 15:42:08 UTC
The problem is likely in wrong order of changes in TC.getLookup and
TC.Registry.getCurrentNodes. The desired behaviour is likely that when
currentNodes are changed, lookup shall already contain the correct
content. Attached patch shall fix it. I'll write some tests and then
apply it.

Comment 12 Jaroslav Tulach 2003-08-22 12:43:52 UTC
Checking in src/org/openide/windows/DefaultTopComponentLookup.java;
/cvs/openide/src/org/openide/windows/DefaultTopComponentLookup.java,v
 <--  DefaultTopComponentLookup.java
new revision: 1.14; previous revision: 1.13
done
Checking in src/org/openide/windows/TopComponent.java;
/cvs/openide/src/org/openide/windows/TopComponent.java,v  <-- 
TopComponent.java
new revision: 1.102; previous revision: 1.101
done
Processing log script arguments...
More commits to come...
Checking in
test/unit/src/org/openide/windows/TopComponentActivatedNodesTest.java;
/cvs/openide/test/unit/src/org/openide/windows/TopComponentActivatedNodesTest.java,v
 <--  TopComponentActivatedNodesTest.java
new revision: 1.3; previous revision: 1.2
done
Comment 13 Jaroslav Tulach 2003-08-22 12:45:54 UTC
*** Issue 35701 has been marked as a duplicate of this issue. ***
Comment 14 Jaroslav Tulach 2003-08-22 18:14:41 UTC
Merged to QBE200308200100:

Checking in src/org/openide/windows/DefaultTopComponentLookup.java;
/cvs/openide/src/org/openide/windows/DefaultTopComponentLookup.java,v
 <--  DefaultTopComponentLookup.java
new revision: 1.13.2.1; previous revision: 1.13
done
Checking in src/org/openide/windows/TopComponent.java;
/cvs/openide/src/org/openide/windows/TopComponent.java,v  <-- 
TopComponent.java
new revision: 1.101.2.1; previous revision: 1.101
done
Comment 15 pzajac 2003-08-25 11:48:26 UTC
Verified in dev build dev build [200308250100]. 
Comment 16 Marian Mirilovic 2003-09-03 15:03:33 UTC
x
Comment 17 Jan Chalupa 2003-11-03 15:34:53 UTC
*** Issue 35701 has been marked as a duplicate of this issue. ***
Comment 18 scanti 2008-11-10 10:22:45 UTC
Created attachment 73574 [details]
Actions Are disabled
Comment 19 scanti 2008-11-10 10:23:56 UTC
I think I have to reopen this issue.
In my application based on the NB platform, sometimes the find(CTRL+F) and replace(CTRL+H) appears disabled.

I was able to reproduce it with my custom file type, with .txt file and .xml file
If I change TopComponent and then I come back to the first one, most of times they are not disabled anymore.
It is likely to be a NetBeans bug.

I have attached an image to clarify the problem
Comment 20 Lukas Hasik 2008-11-10 15:22:18 UTC
I'm decreasing the priority. As it isn't stopper for the 6.5 release. Please, be aware that this won't be fixed in 6.1
as it was released "long" time ago. 

If we'll find a fix then we can fix it for 7.0 or provide patch for 6.5. Maybe it should be tracked as new issue as this
one is really old...
Comment 21 Jaroslav Tulach 2009-03-09 17:19:19 UTC
Find action is provided by openidex module.
Comment 22 Victor Vasilyev 2009-11-16 10:49:08 UTC
Please, reassign this issue to a component that the openidex module belongs to.
It is not the Utilities/Search.

This issue should be validated for the latest version of the NB and the use case described above by scanti.
Comment 23 Jesse Glick 2009-11-20 10:15:52 UTC
http://spreadsheets.google.com/pub?key=tITVLlDs39AbmQ_n7Cq2mGQ&single=true&gid=5&output=html confirms that openidex -> Utilities/Search.
Comment 24 Jaroslav Havlin 2011-08-09 08:35:02 UTC
Sorry, but there is no plan to fix this issue. If it is important for you, feel free to re-open it, or contribute your patch.
Comment 25 Jesse Glick 2011-08-10 20:51:44 UTC
This was originally FIXED in 3.6. scanti's is probably unrelated and may or may not be a bug in NB; should be filed separately if still reproducible.