This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 34562 - ProjectEditorSupport.Env shall not be public
Summary: ProjectEditorSupport.Env shall not be public
Status: CLOSED WONTFIX
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Infrastructure (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: issues@projects
URL:
Keywords: API
Depends on:
Blocks:
 
Reported: 2003-06-24 14:52 UTC by Jaroslav Tulach
Modified: 2004-04-19 16:32 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2003-06-24 14:52:44 UTC
Do you really need ProjectEditorSupport.Env to be
public? I doubt so, that is why I suggest to
remove it from the API and have it a private impl
until somebody needs to update it.
Comment 1 Vitezslav Stejskal 2003-06-24 16:34:06 UTC
I don't think so, clients have to subclass it and provide
implementation of findSupport() abstract method. BTW, why is the Env
innerclass public in *EditorSupport classes in openide?

Anyway, I'll think about it a bit more, maybe we shouldn't blindly
copy openide concepts ;-).
Comment 2 Jaroslav Tulach 2003-06-25 09:46:44 UTC
Better than copying is learning from openide mistakes. Why is
CloneableEditorSupport.Env public is easy, because it needs to be
implemented. Why is DataEditorSupport.Env public is questionable,
probably I thought that somebody will want to reuse it for editing
other than primary file of a data object. But as ProjectMember has
only one file, I do not think that such a need applies to projects. In
my opinion the Env can be either completely hidden or created using a
factory method.
Comment 3 Vitezslav Stejskal 2003-11-24 14:00:24 UTC
As described in
http://www.netbeans.org/servlets/ReadMsg?msgId=619519&listName=nbdiscuss the
current work on projects prototype has been stopped.
Comment 4 Jan Becicka 2003-11-25 13:47:05 UTC
Marking issue as VERIFIED --->
Comment 5 Jan Becicka 2003-11-25 13:51:36 UTC
---> CLOSED