This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33701 - I18N - hardcoded font sizes in source code not relative to global font
Summary: I18N - hardcoded font sizes in source code not relative to global font
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: I18N
Depends on:
Blocks: 33246
  Show dependency tree
 
Reported: 2003-05-18 17:48 UTC by Ken Frank
Modified: 2003-12-11 14:27 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2003-05-18 17:48:40 UTC
Analysis of source code of current product shows
some some calls to setFont that hardcode a certain
font
size that isn't relative to global font size.

Usually, fonts are obtained from the global font
size
value of the product. But sometimes specific font
sizes
are wanted, and if so, they should be assigned
based on
a relative offset from the default font size
instead of
as a specific size.

This is because the localized products will soon
be able
to set the default font size needed for proper
appearance
of their character sets, and hardcoded fonts may
be too
small for meeting those requirements.

If there are other parts of code where hardcoded
font siz
e
might be set other than setFont, can you also
review it?
If the code shown below is not part of
product,please
close issue.

Issue marked with FONTSIZE keyword which means it
will
not be placed on dashboards for 3.5 or nevada as
needing waiving but fixes still need to be for the
ML
release of 3.5/Nevada.

Also will mark as blocking 33246, general task on
resizing of windows, which deals also with font
size
setting.

Specific calls to setFont seen in source code:
taRevLog.setFont(new java.awt.Font("Default", 0,
11));
Comment 1 Martin Entlicher 2003-05-19 12:07:20 UTC
The problem is in
vcscore/src/org/netbeans/modules/vcscore/ui/views/types/LogInfoPanel.java
Comment 2 Martin Entlicher 2003-05-19 12:21:12 UTC
Fixed in the main trunk:
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/views/types/LogInfoPanel.java,v 
<--  LogInfoPanel.java
new revision: 1.2; previous revision: 1.1
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/views/types/LogInfoPanel.form,v 
<--  LogInfoPanel.form
new revision: 1.2; previous revision: 1.1

And in projects branch:
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/views/types/LogInfoPanel.form,v 
<--  LogInfoPanel.form
new revision: 1.1.72.1; previous revision: 1.1
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/views/types/LogInfoPanel.java,v 
<--  LogInfoPanel.java
new revision: 1.1.72.1; previous revision: 1.1
Comment 3 Ken Frank 2003-06-10 19:34:55 UTC
if verification should be in ide itself, 
can you tell us what specific windows 
correspond to actual code that was fixed ?

ken.frank@sun.com
Comment 4 Martin Entlicher 2003-06-11 09:53:47 UTC
It seems, that this class is not used anywhere in the code.
Therefore this does not correspond to any specific window, so I don't
think that this is necessary to integrate into NetBeans 3.5.
Comment 5 Jiri Kovalsky 2003-06-11 11:33:24 UTC
Okay, so wouldn't it be better to remove FONTSIZE keyword so that some
statistics are not messed ?
Comment 6 Ken Frank 2003-06-11 16:10:10 UTC
removing fontsize keyword since this area
is not part of functionality of release35.
ken.frank@sun.com
6/11/2003
Comment 7 Jiri Kovalsky 2003-07-08 14:57:20 UTC
Verified in the sources. July 8, 2003 3:57 p.m. CET