This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 29671 - Storage of old Install-Before's/After's is buggy
Summary: Storage of old Install-Before's/After's is buggy
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on:
Blocks: 13880 28126
  Show dependency tree
 
Reported: 2002-12-20 16:44 UTC by Jesse Glick
Modified: 2008-12-22 19:36 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2002-12-20 16:44:33 UTC
And probably no longer necessary. Originally
introduced to LoaderPoolNode to ensure that user
changes to the pool order would be persisted - by
checking the old orderings, you can see if the new
orderings would have changed them.

But:

1. Utilities.topologicalSort should be stable when
ordering constraints do not contradict the current
ordering. And it is fast. So it should be safe to
always attempt a resort.

2. There were various bugs in this system: #13880,
#28126. The current code also keeps around
*deleted* orderings (converse of #28126) and
(worse) keeps around ordering info for loaders
which no longer exist (sometimes causing NPEs)!

So can probably just remove storage of the old
IB/IA maps and always do a resort. For
bidirectional settings compat, the old maps will
be read and discarded; and writing the pool will
write fresh empty maps (which should be harmless
to older builds).
Comment 1 Jesse Glick 2002-12-20 17:33:29 UTC
Note one effect of the proposed change: if you have rearranged the
loader pool in such a way as to violate one or more declared ordering
constraints from module layers, on next startup the pool will be
resorted to satisfy these constraints anyway. Not great, but on the
other hand this already happened when modules containing loaders are
turned on or off.

For the future it is intended to store loader info (if there is such a
thing at all) in a .settings file in a folder, using the normal folder
ordering system, which is better tested and better able to handle
upgrades.
Comment 2 Jesse Glick 2002-12-20 19:58:23 UTC
committed     Up-To-Date  1.66       
core/src/org/netbeans/core/LoaderPoolNode.java
Comment 3 Marian Mirilovic 2005-07-13 13:20:35 UTC
closed