This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 13880 - Wrong order of loaders when upgrading from boston IE to pilsen CE
Summary: Wrong order of loaders when upgrading from boston IE to pilsen CE
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on: 29671
Blocks: 13827
  Show dependency tree
 
Reported: 2001-07-24 14:27 UTC by _ rkubacki
Modified: 2008-12-23 10:36 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2001-07-24 14:27:18 UTC 
If I run pilsen_fcs build with userdir from boston IE the loaders are not
ordered correctly. ServletDataLoader is not before JavaDataLoader as is
specified in manifest.

After disabling and enabling of module they are sorted correctly. Maybe that one
of the reasons is that ServletDataLoader was not present in boston. It is a new
class.
Comment 1 Jan Zajicek 2001-07-25 13:33:22 UTC 
Assigning and ccing. Folks do you know what can be wrong?
Comment 2 Jesse Glick 2001-07-25 14:17:27 UTC 
I don't know, will investigate. BTW
-J-Dorg.netbeans.core.LoaderPoolNode=0 and attach ide.log is helpful
for diagnostics.
Comment 3 Jesse Glick 2001-07-25 14:39:28 UTC 
By the way, after correcting some unrelated bugs, this does not happen
with the trunk version; Java Servlets is placed above Java Source
Objects.
Comment 4 Jesse Glick 2001-07-25 18:31:32 UTC 
I don't have time to test thoroughly but here is a patch which I
believe fixes it in release32 branch (for
core/src/org/netbeans/core/LoaderPoolNode.java):

     */
     private static synchronized void readPool (ObjectInputStream ois)
     throws IOException, ClassNotFoundException {
+        // #13880: keep any manifest-provided install before/after
information,
+        // rather than overwriting the map with a (possibly
incomplete or obsolete)
+        // deexternalized mapping.
+        Map oldInstallBefores = installBefores;
+        Map oldInstallAfters = installAfters;
         installBefores = (Map) ois.readObject ();
         installAfters = (Map) ois.readObject ();
+        installBefores.putAll(oldInstallBefores);
+        installAfters.putAll(oldInstallAfters);
 
         HashSet classes = new HashSet ();
         LinkedList l = new LinkedList ();
Comment 5 Jesse Glick 2001-07-25 19:13:39 UTC 
Fix should be applied in the trunk. Someone who wishes to merge to
release32, please try the patch below.
Comment 6 Jan Zajicek 2001-07-26 16:46:25 UTC 
Verified in the trunk (rev1.48). Also verified the patch for Pilsen.
Yarda can you do the code review of the fix for integration into
Pilsen. Also Ales, will you apply the fix into Pilsen?
Comment 7 akemr 2001-07-27 13:13:56 UTC 
Integrated into pilsen_fcs and release32
Comment 8 Jan Zajicek 2001-08-14 08:42:23 UTC 
Correcting the Version filed.
Comment 9 Quality Engineering 2003-07-01 16:41:27 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.