In a dev build from today, Ctrl-PageUp and Ctrl-PageDown stopped working to cycle editor tabs. I added an alternative binding Ctrl-Alt-Left for “Previous Tab” and that does get honored.
Confirmed that this is a regression: works fine in a dev build from Nov 04. Makes IDE barely usable, since I use this keyboard shortcut constantly, and I do not want to remember a different one when (for example) Chrome also uses it to switch tabs.
JDK 8u92, XFCE desktop.
Works fine in Product Version: NetBeans IDE Dev (Build 201608290002)
Java: 1.8.0_71; Java HotSpot(TM) 64-Bit Server VM 25.71-b15
Runtime: Java(TM) SE Runtime Environment 1.8.0_71-b15
System: Linux version 3.13.0-37-generic running on amd64; UTF-8; cs_CZ (nb)
Linux Mint 17.1 with Cinnamon
Also works fine in yesterday's build from profiler-main on Windows 7.
Just faced this issue.
I'm on Ubuntu Linux 16.04 with Unity desktop and GTK 3.18.9 (libgtk package exact version 3.18.9-1ubuntu3.1).
What I'm observing is Ctrl-PageUp/Down cause horizontal page scrolling: Ctrl+PageUp scrolls the editor a page right, Ctrl+PageUp scrolls the editor a page left.
Really annoying since I prefer using these keyboard shortcuts instead of Ctrl+Tab.
Product Version: NetBeans IDE 8.2 RC (Build 201609140952)
Java: 1.8.0_101; Java HotSpot(TM) 64-Bit Server VM 25.101-b13
Runtime: Java(TM) SE Runtime Environment 1.8.0_101-b13
System: Linux version 4.4.0-38-generic running on amd64; UTF-8; it_IT (nb)
Reproducible in a new build, but only when using `--laf Nimbus`.
ant clean build-nozip tryme -Dtryme.arg.nimbus='--laf Nimbus' -Dcluster.config=minimal -Dtryme.arg.nbopen='--open /tmp/one.txt /tmp/two.txt /tmp/three-with-long-lines.txt'
Confirmed AlexFalappa’s finding that the keys now perform horizontal scrolling in the editor, rather than being captured by the NB window system to switch tabs.
You never know what you are going to find when you go looking!
The first bad revision is:
user: Ralph Benjamin Ruijs <firstname.lastname@example.org>
date: Mon Mar 21 16:35:53 2016 +0100
summary: Prototype Pin Debug Watch
Indeed the following hotfix seems to fix the issue (at what cost I am not sure):
diff --git a/editor/src/org/netbeans/modules/editor/NbEditorUI.java b/editor/src/org/netbeans/modules/editor/NbEditorUI.java
@@ -256,7 +256,7 @@
// Add the scroll-pane with the component to the center
- JScrollPane scroller = new JScrollPane(layers);
+ JScrollPane scroller = new JScrollPane(/* TODO #267807 layers */component);
// remove default scroll-pane border, winsys will handle borders itself
The problematic UI code appears to have been introduced as part of #258764.
I confirm that I was using the Nimbus LAF too.
@Jesse Glick did you checked your hot fix doesn't break the pinned watch feature introduced in the issue you mention?
Unfortunately the shortcuts do not work on the Darcula LAF too (just tested with Darcula LAF for NetBeans plugin version 1.5 available from http://plugins.netbeans.org/plugin/62424/darcula-laf-for-netbeans).
The observed behaviour is the same as with the Nimbus LAF: horizontal scrolling
*** Bug 268168 has been marked as a duplicate of this bug. ***
> did you checked your hot fix doesn't break the pinned watch feature
Probably it does break this new feature, whatever it is (I have never even tried to use it), whereas navigating between editor tabs is a fundamental task I do several times a minute. This is just a hotfix to make dev builds tolerable again, not a proposed patch.
@Jesse: See a proposed solution for the DarculaLaf at https://github.com/Revivius/nb-darcula/pull/128 . Perhaps the Nimbus issue is related too?
Bad day; the addInputMapsWithoutCtrlPageUpAndCtrlPageDown is already in effect in Nimbus L&F.
It seems that NB's NimbusLFCustoms causes premature JScrollPane initialization, which installs the UI and caches values for input maps - loading from the Swing defaults which contains ctrl-pagedown.
Should be fixed in jet-main#e424830aeb3f
Integrated into 'main-silver', will be available in build *201611110001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
User: Svata Dedic <email@example.com>
Log: #267807: recover tab navigation in Nimbus - scrollpane was initialized and its values populated from default
Great, I will verify as soon as I have a moment.
Working for me in 29830a54cf64, thanks!
Hmm, I think this is not really fixed. Page Up/Down do work fine at first. But then at some point after using the IDE for a while, they stop working; the only workaround is to restart. I have not managed to identify the trigger condition.
Is it worth to include in a patch (considering it is only a partial fix) ?
I'm going to let Jesse answer that last question, but either way I would suggest reopening this issue.
Hmm, in a new dev build this seems to be broken even immediately after startup, so the only workaround is to stop using Nimbus. But I am unable to reproduce in a fresh user directory.
I guess it makes sense to backport, seeing as it seems to fix the reproducible case at least. I am not sure I can spare the time right now to bisect my user directory looking for a reproduction case.
OK, backported as 606211bc9192
Unfortunately I does not work at windows at all -> reopening