This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 262628 - Ecma6 hint does not cover all features
Summary: Ecma6 hint does not cover all features
Status: RESOLVED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Editor (show other bugs)
Version: 8.2
Hardware: PC All
: P2 normal (vote)
Assignee: Milutin Kristofic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-30 09:36 UTC by Petr Hejl
Modified: 2016-08-23 01:55 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hejl 2016-06-30 09:36:33 UTC 
The hint about ecma6 is problematic as it is based purely on lexed (new) tokens.
Such aproach has two problems:
1) it does not handle cases of new features without such token, such as default parameter values, generator functions, binary literals etc.
2) valid (non strict mode) ecma5 code may use such keywords as identifiers

Also it would be nice to have a hint fix similar to what we have done form ecma7.

See Ecma6Rule.java and Ecma7Rule.java.
Comment 1 Milutin Kristofic 2016-08-22 10:59:56 UTC 
I changed as many as possible hints to visitor method and I made it similar to Ecma7 hints. Thank you for a tip. http://hg.netbeans.org/web-main/rev/6f512a6b9d0c
Comment 2 Quality Engineering 2016-08-23 01:55:40 UTC 
Integrated into 'main-silver', will be available in build *201608230002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/6f512a6b9d0c
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #262628 - Ecma6 hint does not cover all features