This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 256049 - Unknown variables in newly created JET QuickStart Basic project
Summary: Unknown variables in newly created JET QuickStart Basic project
Status: VERIFIED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: OJET (show other bugs)
Version: 8.2
Hardware: PC Linux
: P3 normal (vote)
Assignee: Milutin Kristofic
URL:
Keywords: 81_HR_FIX
Depends on:
Blocks:
 
Reported: 2015-10-20 13:05 UTC by Jiri Kovalsky
Modified: 2015-10-22 13:56 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screenshot of error annotations in one of newly created SCSS files. (41.64 KB, image/png)
2015-10-20 13:05 UTC, Jiri Kovalsky
Details
patch small hack (1.45 KB, patch)
2015-10-20 16:07 UTC, Milutin Kristofic
Details | Diff
Still experiencing the same issue in today's daily build. (134.68 KB, image/png)
2015-10-21 16:28 UTC, Jiri Kovalsky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2015-10-20 13:05:50 UTC
Created attachment 156837 [details]
Screenshot of error annotations in one of newly created SCSS files.

Product Version: NetBeans IDE Dev (Build 201510200002)
Java: 1.8.0_60; Java HotSpot(TM) 64-Bit Server VM 25.60-b23
Runtime: Java(TM) SE Runtime Environment 1.8.0_60-b27
System: Linux version 3.13.0-37-generic running on amd64; UTF-8; cs_CZ (nb)

Description:
============
If user creates new Oracle JET QuickStart Basic sample project, it contains errors from the very start. In _oj.utilities.urls.scss file there are three unrecognised variables - see attached screenshot.

Steps to reproduce:
===================
1. Install Oracle JET HTML Editor plugin to the latest NetBeans development build.
2. Invoke "File > New Project..." from main menu.
3. Select "HTML5/JavaScript" project category.
4. Select "Oracle JET QuickStart Basic" project and push "Next >" button.
5. Push "Finish" button.

Expected: The new project is created and there are no files with error badges.

Actual: The new project is created and "scss" node under "OracleJETApplication > Site Root" is marked with "Contains errors" badge.
Comment 1 Milutin Kristofic 2015-10-20 13:28:43 UTC
The url in css has different syntax than in less and sass. Our parser is combining css, less and sass, therefore it is difficult to parse url(http://something) and url(string + var) in one parser. It is already known problem.

*** This bug has been marked as a duplicate of bug 238988 ***
Comment 2 Jiri Kovalsky 2015-10-20 13:32:40 UTC
OK, verifying then.
Comment 3 Antonin Nebuzelsky 2015-10-20 13:44:22 UTC
Specifically for the OJET library case - could the errors be ignored in _oj.*.scss files?

Reopening for evaluation for the OJET plugin case.

Mito is looking into it.
Comment 4 Milutin Kristofic 2015-10-20 16:07:59 UTC
Created attachment 156848 [details]
patch small hack

Here is a hack, that disables automatically (during new project creation) css errors in _oj.utilities.urls.scss.
Comment 5 Antonin Nebuzelsky 2015-10-20 16:50:21 UTC
(In reply to Milutin Kristofic from comment #4)
> Here is a hack, that disables automatically (during new project creation)
> css errors in _oj.utilities.urls.scss.

As discussed offline this is a reasonable hack which at least hides the parser problem from the user when playing with the new project created from the Oracle JET QuickStart Basic project template.

Long-term we do need a proper fix in the parser. Such fix should be 81patch-candidate.

Mito, integrate this hack to web-main and release81 branch.
Comment 6 Milutin Kristofic 2015-10-20 16:51:21 UTC
in web-main http://hg.netbeans.org/web-main/rev/e87d9b2b85bd
Comment 7 Antonin Nebuzelsky 2015-10-20 16:57:29 UTC
release81: http://hg.netbeans.org/releases/rev/9f45e90575f5
Comment 8 Quality Engineering 2015-10-21 01:22:56 UTC
Integrated into 'main-silver', will be available in build *201510210002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/e87d9b2b85bd
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #256049 - Unknown variables in newly created JET QuickStart Basic project
Comment 9 Jiri Kovalsky 2015-10-21 16:28:55 UTC
Created attachment 156884 [details]
Still experiencing the same issue in today's daily build.

Product Version: NetBeans IDE Dev (Build 201510210002)
Java: 1.8.0_60; Java HotSpot(TM) 64-Bit Server VM 25.60-b23
Runtime: Java(TM) SE Runtime Environment 1.8.0_60-b27
System: Linux version 3.13.0-37-generic running on amd64; UTF-8; cs_CZ (nb)
Comment 10 Antonin Nebuzelsky 2015-10-22 09:30:26 UTC
(In reply to Jiri Kovalsky from comment #9)
> Created attachment 156884 [details]
> Still experiencing the same issue in today's daily build.


Jirko, two things:

- you need a new version of the OJET plugin, not only the daily build which already has previous version of OJET plugin in userdir, because the fix is in the OJET plugin

- the fix only affects newly created projects from the JET template - if you open already existing project, the errors in this particular file are not ignored
Comment 11 Tomas Mysik 2015-10-22 09:40:17 UTC
One note: the "fix" will stop working once the JET uses the problematic syntax in any other file which will not match the currently-ignored file name. This can happen anytime and will cause "problems" immediately because we always download the latest ZIP when creating a new project (or a sample).
Comment 12 Jiri Kovalsky 2015-10-22 13:47:31 UTC
Product Version: NetBeans IDE Dev (Build 201510220002)
Java: 1.8.0_65; Java HotSpot(TM) 64-Bit Server VM 25.65-b01
Runtime: Java(TM) SE Runtime Environment 1.8.0_65-b17
System: Linux version 3.13.0-37-generic running on amd64; UTF-8; cs_CZ (nb)

Verified in today's trunk build. Thanks!
Comment 13 Jiri Kovalsky 2015-10-22 13:56:13 UTC
Verified.