This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 255112 - Improve logging of JS libraries
Summary: Improve logging of JS libraries
Status: RESOLVED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Libraries (show other bugs)
Version: 8.1
Hardware: All All
: P1 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-09 05:38 UTC by Tomas Mysik
Modified: 2015-09-11 01:22 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Mysik 2015-09-09 05:38:19 UTC 
Currently, we log JS libraries (npm, Bower, CDNJS) only if user edits them (see [1]). We could improve it this way - log JS libraries always when OK button of Project Properties dialog is clicked. The current usage logging events could be renamed (append "_EDIT") and logged without any parameter (or do you have a better idea?). As a result, we would get more relevant information about JS libraries and will not loose information about JS libraries UI usage.

Thanks.
[1] http://wiki.netbeans.org/UsageLoggingSpecification
Comment 1 Tomas Mysik 2015-09-09 06:12:03 UTC 
One idea - we could log libraries whenever the file (package.json etc.) changes. This would be even more relevant (we can listen only on libraries changes so change in e.g. name would be ignored) and would not require any API changes. Of course, if such a file is changed when the IDE is not running, we will not get the data (but we will get them the next time, this is the same for all the usage logging).

Any objections? Thanks.
Comment 2 Vladimir Riha 2015-09-09 07:41:07 UTC 
Wouldn't it be biased by e.g. project rename or when start file has changed? These changes are being synced with package/bower.json right? OTOH it is not very often action so the numbers from project rename will be imho low.
Comment 3 Tomas Mysik 2015-09-09 08:14:25 UTC 
(In reply to Vladimir Riha from comment #2)
> Wouldn't it be biased by e.g. project rename or when start file has changed?
> These changes are being synced with package/bower.json right? OTOH it is not
> very often action so the numbers from project rename will be imho low.

No, the change to be logged must happen in libraries.
Comment 4 Tomas Mysik 2015-09-10 07:10:49 UTC 
Should be done now, Honzo please review the patches if possible.

Láďo, please verify, thanks.

I have updated the wiki page as well.

http://hg.netbeans.org/web-main/rev/223c6aae0a46
http://hg.netbeans.org/web-main/rev/da36130bb9f1
http://hg.netbeans.org/web-main/rev/7347f508a882
Comment 5 Quality Engineering 2015-09-11 01:22:45 UTC 
Integrated into 'main-silver', will be available in build *201509110002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/223c6aae0a46
User: Tomas Mysik <tmysik@netbeans.org>
Log: #255112 - Improve logging of JS libraries

Bower part.