This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 25418 - NCDFE: HelpSet when executing help sets
Summary: NCDFE: HelpSet when executing help sets
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Help System (show other bugs)
Version: 3.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on: 27776
Blocks:
  Show dependency tree
 
Reported: 2002-07-08 20:41 UTC by Jesse Glick
Modified: 2008-12-23 00:32 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Stack trace (831 bytes, text/plain)
2002-07-08 20:42 UTC, Jesse Glick 		Details
Applied diff (810 bytes, patch)
2002-07-11 20:51 UTC, Jesse Glick 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2002-07-08 20:41:36 UTC 
[dev jul 08] Clicking a help set XML file and
pressing F6 no longer works (regression).
Comment 1 Jesse Glick 2002-07-08 20:42:05 UTC 
Created attachment 6550 [details]
Stack trace
Comment 2 Jesse Glick 2002-07-11 20:49:17 UTC 
Should be fixed in trunk, details to follow. Candidate for 3.4 release
merge.

committed     Up-To-Date  1.7         core/javahelp/manifest.mf
Comment 3 Jesse Glick 2002-07-11 20:51:29 UTC 
Created attachment 6631 [details]
Applied diff
Comment 4 Jesse Glick 2002-07-11 20:57:15 UTC 
[YARDA - review requested]

Dumb oversight. The JavaHelp API module got an
OpenIDE-Module-Public-Packages decl which specified that only its API,
not impl, classes should be exposed to other modules depending on it.
Unfortunately I forget the JavaHelp API itself (javax.help)! So
modules depending on this autoload could not e.g. access
javax.help.HelpSet the way they are supposed to be able to do. A
manifest change corrects it.

To test: mount e.g.
nb_all/usersguide/javahelp/org/netbeans/modules/javahelp/ as a local
FS. Click ide.hs in the Explorer. Click Execute (F6). Without patch,
the attached stack trace is thrown. With patch (just edit the manifest
of modules/autoload/javahelp-api.jar), a JH viewer should open
displaying the help set.

Might also affect any other module besides apisupport which directly
uses javax.help.* APIs. Rochelle I think you have one.
Comment 5 Jaroslav Tulach 2002-07-12 08:09:05 UTC 
I guess this was the reason why Rochelle module that worked in 3.3
(javax.help on classpath) did not work in new version (inspite that it
automatically depended on javahelp module). From this point of view
this is the correct change.

Btw. I also checked the JavaHelp Module API - It does not reference
javax.help API...
Comment 6 Jesse Glick 2002-07-12 17:55:42 UTC 
"I guess this was the reason why Rochelle module that worked in 3.3
(javax.help on classpath) did not work in new version (inspite that it
automatically depended on javahelp module)" - I doubt it. Automatic
dependencies, or the explicit

OpenIDE-Module-Requires: org.netbeans.api.javahelp.Help

will *not* give you direct access to javax.help.*: you are asking that
some Help impl be present in the system, but you are not asking for it
to be on your classpath. To use javax.help.* you must actually declare

OpenIDE-Module-Module-Dependencies: org.netbeans.modules.javahelp/1 > 1.0

to ask for the classpath.

The JavaHelp Module API doesn't mention javax.help.*, it is true.
Actually most of it is really documented in the Open APIs under the
Modules API. I will move those docs, I guess (issue #25594).
Comment 7 Jesse Glick 2002-07-16 13:42:06 UTC 
Merged:

committed     Up-To-Date  1.6.18.1    core/javahelp/manifest.mf
Comment 8 Marian Mirilovic 2002-10-25 13:55:53 UTC 
verified
Comment 9 Quality Engineering 2003-07-01 16:22:22 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.