This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
A bit late, but I think Rochelle was right here - older modules that declared a package dependency on javax.help (e.g. apisupport, apparently TP?) should have been automatically given a dep on org.netbeans.modules.javahelp/1 in 3.4, to let them continue to use the package. org.netbeans.core.modules.NbInstaller permits this kind of thing. Better late than never, right?
Turns out someone cares (BT #4763333).
This is a showstopper for the S1S Application Server plugin. S1S escalated it as a Q-build stopper for the 200210230100 Q-build as it blocks their testing. Please fix asap. In the QBE200210230100 branch, too. Thanks.
It blocks their testing when there is a workaround which requires about ten seconds of effort and which I documented in the BT report?? Whatever, I will fix as soon as I can.
Have patch, untested.
The purpose of the testing is to verify that the S1S4u1 module still works with the NB trunk. I understand this can be easily fixed by the module owner for the next release of the module. However, QA shouldn't be required to touch any of the module's files (including its manifest). Thank you for working on it. Can the patch be made available?
Created attachment 7761 [details] Proposed patch - compiles, but totally untested
Previously posted patch did not work; missing line it.remove(); before break; line - need to remove javax.help package dep while adding org.netbeans.modules.javahelp module dep. Seems to be fixed now. Tried with an old apisupport.nbm (2.10.2, designed for NB 3.3.x). Worked fine, after I fixed that JAR file to include the required Manifest-Version: 1.0 in the manifest header. Specifically tested an operation which accessed javax.help.HelpSet. NbInstaller.java 1.54
Jesse, could you put the fix into the QBE200210230100 branch too? Thanks!
Done; committed to QBE200210230100 branch (NbInstaller.java 1.52.2.1).
Great, thanks.
Created attachment 8109 [details] Proposed patch for 3.4.1
Yarda, Trung, or someone, could I get a quick review of the attached patch? Thanks.
The 341 patch is no worse than the maintrunk one.
In release341: Checking in core/src/org/netbeans/core/modules/NbInstaller.java; /cvs/core/src/org/netbeans/core/modules/NbInstaller.java,v <-- NbInstaller.java new revision: 1.41.28.1; previous revision: 1.41 done
verified fixed
Resolved for 3.4.x or earlier, no new info since then -> closing.