This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 252093 - Support takari-lifecycle-plugin
Summary: Support takari-lifecycle-plugin
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Maven (show other bugs)
Version: 8.1
Hardware: PC Linux
: P3 normal (vote)
Assignee: Tomas Stupka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-25 11:58 UTC by sviperll
Modified: 2015-05-06 14:38 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sviperll 2015-04-25 11:58:54 UTC
[takari-lifecycle-plugin](https://github.com/takari/takari-lifecycle) provides replacement for many standard maven plugins.

takari-lifecycle-plugin can be used as a drop-in replacement for maven-compiler-plugin. Takari provides number of advantages:

 * More precise incremental compilation
 * It always replay all warning messages from compiler, even if no recompilation is necessary.

Unfortunately takari's output is not recognized by netbeans. Error messages are not converted to hyperlinks in output window.

The problem seems to be that netbeans has hard dependency on maven-compiler-plugin. It can be fixed by adding information about takari plugin to [JavaOutputListenerProvider] (http://hg.netbeans.org/main/file/0877331f85a8/maven/src/org/netbeans/modules/maven/output/JavaOutputListenerProvider.java):

````
     private static final String[] JAVAGOALS = new String[] {
         "mojo-execute#compiler:compile", //NOI18N
-        "mojo-execute#compiler:testCompile" //NOI18N
+        "mojo-execute#compiler:testCompile", //NOI18N
+        "mojo-execute#takari-lifecycle-plugin:compile", //NOI18N
+        "mojo-execute#takari-lifecycle-plugin:testCompile" //NOI18N
     };
````
Comment 1 Tomas Stupka 2015-05-04 14:42:58 UTC
fixed in jet-main #05e51b6a6478
Comment 2 Tomas Stupka 2015-05-04 14:43:17 UTC
if this is all that had to be done, thanks
Comment 3 Quality Engineering 2015-05-05 03:27:49 UTC
Integrated into 'main-silver', will be available in build *201505050001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/05e51b6a6478
User: Tomas Stupka <tstupka@netbeans.org>
Log: Issue #252093 - Support takari-lifecycle-plugin
Comment 4 sviperll 2015-05-06 14:38:07 UTC
(In reply to Tomas Stupka from comment #2)
> if this is all that had to be done, thanks

I've verified this fix from main-silver brunch. It works, but requires some modification from takari's side. There was a small difference in log formats of takari and maven-compiler-plugin. maven-compiler-plugin uses comma to to separate file line and row numbers, but Takari uses colon.

https://github.com/takari/io.takari.incrementalbuild/pull/8