This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 249912 - [Dark] Subversion Update Result Table is not readable
Summary: [Dark] Subversion Update Result Table is not readable
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Subversion (show other bugs)
Version: 8.0.2
Hardware: All All
: P4 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords: L&F, PATCH_AVAILABLE, SIMPLEFIX
Depends on:
Blocks:
 
Reported: 2015-01-20 14:19 UTC by lkishalmi
Modified: 2015-01-24 17:58 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Patch for the quick and dirty solution. (842 bytes, patch)
2015-01-20 14:33 UTC, lkishalmi
Details | Diff
correct color (12.08 KB, image/png)
2015-01-20 16:18 UTC, Ondrej Vrabec
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lkishalmi 2015-01-20 14:19:34 UTC
Using Subversion, the updated files are painted black in the UpdateResultsTable. Unfortunately that is not really readable on dark look and feel.

The reason is that the htmlDisplayName UpdateResultNode does not have a proper color. So it would be renered with the default black.

Possible solutions:
  - Quick and dirty hack to only use html rendering when the htmlDisplay name is html
  - Assign some color to the Updated status as well.
  - Use the AnnotationColorProvider to get a htmlDisplayName
Comment 1 Ondrej Vrabec 2015-01-20 14:24:49 UTC
Tools -> Options -> Fonts & Colors -> Versioning.
Redefine the colors for the different statuses so it matches the dark l&f you selected.
Comment 2 lkishalmi 2015-01-20 14:33:46 UTC
Created attachment 151587 [details]
Patch for the quick and dirty solution.
Comment 3 lkishalmi 2015-01-20 14:36:00 UTC
Unfortunately you can't set the color for this status.
Comment 4 Ondrej Vrabec 2015-01-20 15:15:02 UTC
Can you please make a screenshot?
Comment 5 Ondrej Vrabec 2015-01-20 16:18:26 UTC
Created attachment 151589 [details]
correct color

it seems to work and paints correctly in white for me.
Comment 6 lkishalmi 2015-01-21 08:24:11 UTC
Well it happens on DarkNimbus. So it seems it is LAF dependent issue.
I dug furter into Nimbus code, and it seems that the Table.textForeground is semi-hard-coded (not one of the Nimbus standard colors) into the LAF.

So I've patched DarkNimbus LAF and it works now. I mark this issue resolved and open a new one for DarkNimbus LAF.

Thank's for the quick response!
Comment 7 Ondrej Vrabec 2015-01-23 15:37:43 UTC
There were other issues in the update table, anyway (such as different colors than the ones used e.g. in Status table) .

fixed: core-main #9bc251e4214e
Comment 8 Quality Engineering 2015-01-24 02:35:08 UTC
Integrated into 'main-silver', will be available in build *201501240002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/9bc251e4214e
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: Issue #249912 - [Dark] Subversion Update Result Table is not readable
Use the configured colors used in whole subversion support instead specific colors only for update.
Comment 9 lkishalmi 2015-01-24 17:58:33 UTC
Thanks for fixing the hard coded colors!

You might want remove the html bulletpoof vest code once the Dark Nimbus behaves correctly.

For reference, the bug I've filed against the LAF is #249920 (It contains the reqired fix as well)