This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 248985 - Broken error badges
Summary: Broken error badges
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: CSS Editor (show other bugs)
Version: 8.1
Hardware: PC Linux
: P1 normal (vote)
Assignee: Milutin Kristofic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-28 15:23 UTC by Vladimir Riha
Modified: 2015-07-16 01:21 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
IDE log (172.06 KB, text/plain)
2014-11-28 15:23 UTC, Vladimir Riha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2014-11-28 15:23:26 UTC
Created attachment 150769 [details]
IDE log

Please try following:
 - download [1] and open the project in NetBeans
 - open style.css
 - click on the error bulb icon on line 11 and select to filter out problems in current file

=> the error is no longer displayed in editor window (that is as expected) but the file still has error badge. The same happens if you select to filter out problems in e.g. current folder


Thank you



[1] http://services.netbeans.org/synergy/server/api/attachment.php?id=131


Product Version: NetBeans IDE Dev (Build 201411280001)
Java: 1.7.0_71; Java HotSpot(TM) Client VM 24.71-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_71-b14
System: Linux version 3.13.0-35-generic running on i386; UTF-8; en_US (nb)
Comment 1 Vladimir Riha 2014-11-28 15:25:30 UTC
FYI the same works in older NetBeans IDE Dev (Build 201411200001)
Comment 2 Vladimir Riha 2014-11-28 15:28:46 UTC
Last comment: The same feature works in Scss/Less files just fine
Comment 3 Vladimir Riha 2014-11-28 15:37:27 UTC
Please disregard the Less/Scss comment. It seems like it works OK if file (css/less/scss) is not in folder but directly in site root.

If file is in some folder, then error badges does not work correctly at all. They are either not displayed when they should be or remained displayed even after fixing the incorrect syntax or after using the "filter out" feature.
Comment 4 Milutin Kristofic 2015-03-05 18:23:24 UTC
This should fixed it. http://hg.netbeans.org/web-main/rev/cacbfb5c52c9
Comment 5 Milutin Kristofic 2015-03-06 09:20:17 UTC
I am still looking on option to refresh icons error status after filtering errors. Because now you must to do following:

1, filter error
2, change document (write or delete something in document)
3, save document

icon is changed if there are no more errors. (it didn't change before my fix in files in folders, only in one inside of root)
Comment 6 Vladimir Riha 2015-03-06 09:31:16 UTC
Thanks, I'll wait with testing.

I'd say it is a "must have" to refresh badges without the need to modify documents (it works that way in 8.0). If users have a lot of files to filter out, it is impractical to update every single one of them.
Comment 7 Quality Engineering 2015-03-07 08:42:13 UTC
Integrated into 'main-silver', will be available in build *201503070001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/cacbfb5c52c9
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #248985 - Broken error badges
Comment 8 Vladimir Riha 2015-04-03 11:11:24 UTC
Reopening so that we won't forget it. The need to update the CSS file to get badges (in Projects window or editor's header) away/back is a regression and knowing how much users asked for this feature, it must be fixed for 8.1.

Thank you
Comment 9 Vladimir Riha 2015-04-17 09:08:00 UTC
The same problem is now with the new same feature for JS files. Could be some CSL problem
Comment 10 Milutin Kristofic 2015-07-14 15:54:04 UTC
I pushed now to web-main fix that will change error badge on file that you filtered errors. I think this fix regression. 

On the other hand, it still doesn't change error badges for other files. That means a lot of reindexing, and it shouldn't work before, since there is no code for that. We can make it as a new bug, enhencement.
Comment 11 Milutin Kristofic 2015-07-15 11:42:25 UTC
http://hg.netbeans.org/web-main/rev/541726cb392a
Comment 12 Quality Engineering 2015-07-16 01:21:46 UTC
Integrated into 'main-silver', will be available in build *201507160001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/541726cb392a
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #248985 - Broken error badges