This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 247307 - Change in sass compiler command line parameters
Summary: Change in sass compiler command line parameters
Status: VERIFIED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: CSS Preprocessors (SASS, LESS, ...) (show other bugs)
Version: 8.1
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-19 14:05 UTC by Vladimir Riha
Modified: 2014-09-30 09:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2014-09-19 14:05:26 UTC 
Sass compiler 3.4.3 (and maybe some earlier version as well) now uses --sourcemap parameter by default. Which means there is no way to disable source maps in IDE.

From sass help:

        --sourcemap=TYPE             How to link generated output to the source files.
                                       auto (default): relative paths where possible, file URIs elsewhere
                                       file: always absolute file URIs
                                       inline: include the source text in the sourcemap
                                       none: no sourcemaps


The default scss compilation then contains warning: 

"/usr/local/bin/sass" "--cache-location" "/home/vriha/.cache/netbeans/8.0/sass-compiler" "--sourcemap" "/tmp/HTML5Application/public_html/sass/main.scss" "/tmp/HTML5Application/public_html/css/main.css"
DEPRECATION WARNING: Passing --sourcemap without a value is deprecated.
Sourcemaps are now generated by default, so this flag has no effect.


Thank you
Comment 1 Tomas Mysik 2014-09-22 05:26:18 UTC 
Could you please try to find in which Sass version this has changed?

Thanks.
Comment 2 Tomas Mysik 2014-09-22 05:27:13 UTC 
And what should be the exact command then? Thanks.
Comment 3 Vladimir Riha 2014-09-22 05:56:50 UTC 
Sure, I'll try to find the version. The change is imho:
 - if source maps should be created, don't use the sourcemap parameter at all (the default "auto" seems to work for me at least in the cases I've tried)
 - if source maps should not be created, use --sourcemap=none
Comment 4 Tomas Mysik 2014-09-22 05:58:25 UTC 
(In reply to Vladimir Riha from comment #3)
>  - if source maps should not be created, use --sourcemap=none

When we want this?
Comment 5 Vladimir Riha 2014-09-22 06:26:14 UTC 
In Tools|Options|Misc|CSS Prep., there is a checkbox with a bit cryptic label "Generate extra information".
Comment 6 Vladimir Riha 2014-09-22 06:43:16 UTC 
First Sass version that autogenerates source maps without --sourcemap is 3.4.0, details http://sass-lang.com/documentation/file.SASS_CHANGELOG.html
Comment 7 Tomas Mysik 2014-09-22 08:05:15 UTC 
Should be fixed now, please verify. BTW, perhaps a patch candidate?

Thanks.

http://hg.netbeans.org/web-main/rev/920fbefe76e5
Comment 8 Quality Engineering 2014-09-24 12:50:37 UTC 
Integrated into 'main-silver', will be available in build *201409241121* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/920fbefe76e5
User: Tomas Mysik <tmysik@netbeans.org>
Log: #247307 - Change in sass compiler command line parameters
Comment 9 Vladimir Riha 2014-09-29 08:56:02 UTC 
Verified, thank you

Product Version: NetBeans IDE Dev (Build 201409290001)
Java: 1.7.0_67; Java HotSpot(TM) Client VM 24.65-b04
Runtime: Java(TM) SE Runtime Environment 1.7.0_67-b01
System: Linux version 3.13.0-35-generic running on i386; UTF-8; en_US (nb)
Comment 10 Vladimir Riha 2014-09-29 08:56:50 UTC 
(In reply to Tomas Mysik from comment #7)
> Should be fixed now, please verify. BTW, perhaps a patch candidate?

Agree
Comment 11 Tomas Mysik 2014-09-29 09:40:56 UTC 
Mariane, can I transplant this patch right now or not? Thanks a lot.
Comment 12 Marian Mirilovic 2014-09-29 10:54:29 UTC 
(In reply to Tomas Mysik from comment #11)
> Mariane, can I transplant this patch right now or not? Thanks a lot.

Yes, please do so. Thanks in advance.
Comment 13 Tomas Mysik 2014-09-29 11:04:54 UTC 
Transplanted to the releases repo, branch release801. Thanks.

http://hg.netbeans.org/releases/rev/83537a2ab9d7
http://hg.netbeans.org/releases/rev/f31a471a5035
Comment 14 Quality Engineering 2014-09-30 09:08:19 UTC 
Integrated into 'releases/release801', will be available in build *201409300841* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/83537a2ab9d7
User: Tomas Mysik <tmysik@netbeans.org>
Log: #247307 - Change in sass compiler command line parameters
(transplanted from 920fbefe76e59f72358653c88fcb5f55073a7f06)