Since the editor toolbar is designed to save
screen real estate, and 
since modules can add items to it, wouldn't it be
nicer to use a single toolbar button whose
associated action would change, rather than having
a Stop Macro Recording button (which does nothing
if you are not recording a macro) and a seperate
Start Macro Recording button?

Basically, which you click Start Recording Macro,
the icon and tooltip 
(and underlying action) would change to Stop
Recording Macro.  This
should be easy - just an action subclass which
delegates to one or 
the other and fires changes in display name and
icon when it changes
which action it is delegating to (I do not think
"Toggle Recording Macro" would be intuitive, so
it's better to do it this way).