This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 241656 - MavenWizardIterator doesn't allow to configure additional properties for iterator created via ArchetypeWizards.definedArchetype.
Summary: MavenWizardIterator doesn't allow to configure additional properties for iter...
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Maven (show other bugs)
Version: 8.0
Hardware: PC Windows 7
: P3 normal with 1 vote (vote)
Assignee: Milos Kleint
URL:
Keywords:
Depends on: 236251
Blocks:
  Show dependency tree
 
Reported: 2014-02-10 19:23 UTC by Denis Anisimov
Modified: 2014-02-14 14:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Anisimov 2014-02-10 19:23:18 UTC 
This issue is a "regression".
I suppose there were reasons to implement 
MavenWizardIterator in the current way, but still. The behavior differs from NB 7.4 and make impossible to configure additional properties if ArchetypeWizards.definedArchetype is used.

The latter method (ArchetypeWizards.definedArchetype) creates Acrhetype, which is used to instantiate MavenWizardIterator.
Its "initialize" method instantiate BasicWizardPanel with last parameter value archetype == null.
The last parameter initialize "additional" field for BasicWizardPanel is used as a flag for showing additional properties UI.
As a result this flag equals false. And the latter UI is never shown.

NB 7.4 version instantiate BasicWizardPanel with "true" as last argument.
panels.add(new BasicWizardPanel(vg, null, true, true));

Could you please provide additional argument for MavenWizardIterator, which could be used to set last BasicWizardPanel CTOR parameter value.
So this value should not be based on the "archetype" attribute value.
Comment 1 Milos Kleint 2014-02-11 12:09:36 UTC 
related to issue 236251
Comment 2 Milos Kleint 2014-02-11 14:52:25 UTC 
http://hg.netbeans.org/core-main/rev/e1dea0c7d546

changed the behaviour mostly because of a stuck Downloading Archetype progress bar. I've done some additional debugging and it appears that the stuck progress is not related to repository indexing as previously though. More likely to going back and forth in the wizard (which is meant to "finish" the progress bar but for some reason sticks (but no work is done on the background in the meantime)

The possible problem is likely somewhere in progress bar implementation itself which we stress out by calling finish() twice for each start().. if the first finish() comes before the start, we get a log entry, if both finish() methods are triggered after start() no logging happens
Comment 3 Milos Kleint 2014-02-13 10:27:26 UTC 
http://hg.netbeans.org/core-main/rev/023fd4932937
Comment 4 Quality Engineering 2014-02-14 02:52:58 UTC 
Integrated into 'main-silver', will be available in build *201402140001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/023fd4932937
User: Milos Kleint <mkleint@netbeans.org>
Log: #241656 revert to downloading the archetype in all cases, not only the Project from Archetype scenario, some plugins depend on the old behaviour
Comment 5 Denis Anisimov 2014-02-14 14:41:33 UTC 
Thanks!