This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 235452 - Auto un-indentation of closing html tags not working
Summary: Auto un-indentation of closing html tags not working
Status: CLOSED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Editor (show other bugs)
Version: 7.4
Hardware: PC Linux
: P1 normal (vote)
Assignee: Marek Fukala
URL:
Keywords: 7.4_HR_FIX, REGRESSION
Depends on:
Blocks:
 
Reported: 2013-09-03 11:11 UTC by kaha6uc
Modified: 2013-09-12 01:02 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kaha6uc 2013-09-03 11:11:48 UTC 
Whilst indenting nested HTML tags correctly, closing these tags do not get automatically indented back to the position of their corresponding opening tags.

How to reproduce:

1. Create a new html file
2. Write this:

<table>
<tr>
<td>
text here

3. the tr, the td, and the text are indented perfectly
4. hitting enter and writing

</td>
</tr>
</table>

keeps these last tags in the same indentation depth - under text.

I am aware that writing <td> auto-hints the closing </td>, but it's not usable in all cases.

It last worked correctly in 7.3.1.

Product Version: NetBeans IDE Dev (Build 201309030001)
Java: 1.7.0_13; Java HotSpot(TM) 64-Bit Server VM 23.7-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_13-b20
System: Linux version 3.9.4-debian-c4 running on amd64; UTF-8; en_GB (nb)
Comment 1 Marek Fukala 2013-09-05 08:29:31 UTC 
hmm, reproducible. It is a regression. Thank you for the report.
Comment 2 Marek Fukala 2013-09-05 08:52:11 UTC 
fixed in web-main#83aaf6740350

regression of implementing the editor.typinghooks. I forgot to add a unit test for  this :-|. 

I believe as this is productivity breaker and regression it deserves P2 and IMO must be fixed in 7.4.
Comment 3 Marek Fukala 2013-09-05 08:54:13 UTC 
BTW the fix is trivial and 100% safe + I've added the unit tests.
Comment 4 Vladimir Riha 2013-09-05 08:54:23 UTC 
Agree
Comment 5 kaha6uc 2013-09-05 09:45:46 UTC 
Thank you for this! You're great! Keep up the good work!

Cheers :)
Comment 6 Jan Becicka 2013-09-05 12:23:09 UTC 
patch is OK
Comment 7 Quality Engineering 2013-09-06 01:36:28 UTC 
Integrated into 'main-silver', will be available in build *201309060001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/83aaf6740350
User: Marek Fukala <mfukala@netbeans.org>
Log: #235452 - Auto un-indentation of closing html tags not working
Comment 8 Vladimir Riha 2013-09-09 06:36:48 UTC 
Verified in trunk, please continue with integration to release74 as described in [1]. Thank you


[1] http://wiki.netbeans.org/NetBeans_74_HighResistance


Product Version: NetBeans IDE Dev (Build 201309090001)
Java: 1.7.0_40; Java HotSpot(TM) Client VM 24.0-b56
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b43
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 9 Marek Fukala 2013-09-09 07:59:29 UTC 
changeset:   271847:b8210bb66a3d
branch:      release74
summary:     #235452 - Auto un-indentation of closing html tags not working
Comment 10 Vladimir Riha 2013-09-10 15:23:40 UTC 
Verified in RC1

Product Version: NetBeans IDE 7.4 RC1 (Build 201309092300)
Java: 1.7.0_40; Java HotSpot(TM) Client VM 24.0-b56
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b43
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)