This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 232947 - Add AngularJS support for JSF XHTML files
Summary: Add AngularJS support for JSF XHTML files
Status: VERIFIED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: AngularJS (show other bugs)
Version: 7.4
Hardware: PC Linux
: P3 normal (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-18 06:45 UTC by Vladimir Riha
Modified: 2013-07-23 07:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2013-07-18 06:45:50 UTC
Angular seems to be working with JSF (I tried AngularPhoneCat in JSF page), but editor in IDE does not offer code completion for directives or their values etc. Although DTD for JSF XHTML is XHTML 1.0 Transitional, it is compiled to HTML5
Comment 1 Marek Fukala 2013-07-18 14:40:59 UTC
changeset:   258588:60244ac3c9a3
summary:     Making the creation of the embedded javascript source transitional for templating languages (e.g. JSP->HTML->JS) to make the html.editor's JsEmbeddingProviderPlugins to work. This enables the AngularJS and Knockout supports for templating languages as well. So far JSP, PHP and XHTML are switched. Possibly also converts Smarty, Twiggy etc. (those providers which remained in the direct javascript2.editor/JsEmbeddingProvider).
Comment 2 Vladimir Riha 2013-07-22 06:59:53 UTC
Thank you, the changeset [1] should be already in Trunk build but it still
doesn't work. data-* is missing in code completion, it is not properly
recognized, no JS completion...


[1] http://hg.netbeans.org/main-silver/rev/0410851aca2c

Product Version: NetBeans IDE Dev (Build 201307212300)
Java: 1.7.0_40-ea; Java HotSpot(TM) Client VM 24.0-b52
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-ea-b33
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 3 Vladimir Riha 2013-07-22 07:06:54 UTC
I'm sorry, I was too fast.


I'm not sure if data-* should be colored (since facelet JSF is XHTML), but I think ng-* should. The remaining problem is similar to Angular in PHP/JSP:
 - attribute ng-* is not colored as HTML framework directive
 - ng-* is missing in code completion

But JS completion works and {{ }} expressions are recognized
Comment 4 Marek Fukala 2013-07-22 08:59:53 UTC
(In reply to comment #3)
> I'm sorry, I was too fast.
> 
> 
> I'm not sure if data-* should be colored (since facelet JSF is XHTML), but I
> think ng-* should. The remaining problem is similar to Angular in PHP/JSP:
>  - attribute ng-* is not colored as HTML framework directive
>  - ng-* is missing in code completion
> 
> But JS completion works and {{ }} expressions are recognized

I was aware of these issues, I'm sorry, planned to fix bit later...
Comment 5 Marek Fukala 2013-07-22 09:46:21 UTC
changeset:   258936:bde372f1317a
summary:     #232947/2 - enabling the AngularHtmlExtension for non-pure html files
Comment 6 Quality Engineering 2013-07-23 02:38:12 UTC
Integrated into 'main-silver', will be available in build *201307222300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/bde372f1317a
User: Marek Fukala <mfukala@netbeans.org>
Log: #232947/2 - enabling the AngularHtmlExtension for non-pure html files
Comment 7 Vladimir Riha 2013-07-23 07:34:36 UTC
Thank you, now it seems to be OK

Product Version: NetBeans IDE Dev (Build 201307222300)
Java: 1.7.0_40-ea; Java HotSpot(TM) Client VM 24.0-b52
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-ea-b33
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)