This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Time for a new Ant release, see URL! Still in beta, so may or may not make it into NB 3.4. Run: ant -f .../nb_all/ant/build.xml release-helper to get assistance preparing the module for the new release. Be sure to properly implement the new <input> task.
*** Issue 23561 has been marked as a duplicate of this issue. ***
Note: now at 1.5b2.
I know. And final release is planned for July 1 what is 10 days before our Beta3. Do you think it would worth to integrate Ant1.5 even without the implementation of new <input> task?
once again, are we talking about integrating this for 3.4 or the release after that?
aha :-) The current plan is: after 3.4 version. I was just rethinking about putting it into 3.4, but I forgot about consequences it has on Docs. So we will stick with after 3.4 version.
The line: Class-Path: ext/ant-1.4.1.jar ext/ant-optional-1.4.1.jar docs/ant-manual.zip in the manifest.mf of this project makes it VERY annoying to make this upgrade myself to version 3.3.2. Can you please not version the ant filename in the future.
"The line: Class-Path: ext/ant-1.4.1.jar .... in the manifest.mf of this project makes it VERY annoying to make this upgrade myself to version 3.3.2": why? replace modules/ext/ant-1.4.1.jar and modules/ext/ant-optional-1.4.1.jar with the newer versions (but keep the same filenames) and restart NB. Should work (haven't tried it). Anyway how hard is it to replace one line in a file in a JAR? Using Emacs at least, C-x C-f the-jar-file.jar, arrow down to META-INF/MANIFEST.MF, f to open, make changes, C-x C-s to save - you are done. Similar with WinZIP etc. I think. Else unpack, change, repack, not much work.
Ant 1.5 is now released.
BTW I suggest creating a separate branch in ant.netbeans.org (covering ant and ant/docs modules) to implement this, and merging the changes to the trunk as well. The branch can be rooted from release34, so the update NBM would contain *only* changes for Ant 1.5 and no NB 4.0-related changes.
Target milestone was changed from '3.4' to TBD.
I know that this issue relates to Linux. However, as far as I can see, it's still a showstopper for Windows XP, where Ant 1.4.1 thinks it's on Win 98 and cannot handle: <property environment="squiggle" /> This was originally logged as #23561, and marked as a duplicate to this. Is there a workaround that I'm not aware of (I can't see how to get the Ant workaround to work as I can't get the command line argument to ant, and I can't set os.name in the properties file (I assume that it's read only)? tia tc
Tim, I put you on CC of this issue. I don't know of any workaround for you. Did you try to replace Ant1.4.1 with 1.5 (as described in this issue and in FAQ doc)? Does it work for you? After weeks of promises I finally should have time to start work on this issue.
Not specific to Linux, just marked PC/Linux because I filed it and it defaults to web browser's platform. Assuming that (1) this will be done well before 4.0, (2) we would try to supply the NBM for 3.4 users too, (3) 3.4.1 if produced would include it already.
I can't get the workaround to work around. I'm trying to get this working with Forte to trial various SOAP technologies and struggling to get many integrated components working properly. I even seem to have stopped junit working properly now. when I replace ant with 1.5, it simply doesn't have the relevant classes implemented to integrate into netbeans. :-( I'm surprised that this wasn't a more urgent issue as it was first noted on ant in Feb. maybe not many folk use xp. (I can understand why - it's a pretty poor platform. tim
"when I replace ant with 1.5, it simply doesn't have the relevant classes implemented to integrate into netbeans." - details?
WORKAROUND: This is what you can do to upgrade to Ant 1.5: - Replace ant-1.4.1.jar and ant-optional-1.4.1.jar in the modules/ext directory with ant.jar and optional.jar of Ant 1.5. NOTE: DO NOT replace ant.jar in the modules (not: modules/ext) directory. That ant.jar is the Ant integration module, not Ant itself. (Tim Coole, is that why you write: "when I replace ant with 1.5, it simply doesn't have the relevant classes implemented to integrate into netbeans."?). NOTE: The ant.jar and optional.jar in the modules/ext directory must be renamed to ant-1.4.1.jar and ant- optional-1.4.1.jar even though they are really the JARs of Ant 1.5. This is because of the Class-Path in the manifest of modules/ant.jar. For me this workaround works and allows me to use Ant 1.5 with NetBeans 3.4. Jesper de Jong
Jesse, I have question about useful-sources, the folder created by release-helper target. According to your personal judgement you chose subset of all Ant sources and for these sources javadoc and parser database is created. Now when there is no space limitation, do you think I should include all the sources? I tried it and the ant\docs\release\docs\ant-api.zip has about 2MB. (I did one more experiment excluding just "org/apache/tools/ant/taskdefs/optional/**" and that has 1MB). DO you think it is reasonable to include everything?
Now that there is no space limitation, I would suggest just including everything. AFAIK the official Ant distribution does, so we should be consistent with that. If someday they clearly separate their API, then we should match their documentation too.
Starting the wotk on issue.
Created branch ant15_integration. First part of the integration commited: Checking in build.xml; new revision: 1.52.6.2.2.1; previous revision: 1.52.6.2 Checking in manifest.mf; new revision: 1.44.6.1.2.1; previous revision: 1.44.6.1 Checking in docs/manifest.mf; new revision: 1.1.56.1; previous revision: 1.1 Checking in docs/javahelp/org/apache/tools/ant/module/docs/HelpSet.hs; new revision: 1.1.56.1; previous revision: 1.1 Checking in docs/javahelp/org/apache/tools/ant/module/docs/Map.jhm; new revision: 1.1.56.1; previous revision: 1.1 Checking in docs/javahelp/org/apache/tools/ant/module/docs/TOC.toc; new revision: 1.1.56.1; previous revision: 1.1 Checking in docs/release/docs/ant-api.zip; new revision: 1.1.56.1; previous revision: 1.1 Removing docs/release/system/ParserDB/ant141.jcb; new revision: delete; previous revision: 1.1.56 Removing docs/release/system/ParserDB/ant141.jcs; new revision: delete; previous revision: 1.1.56 Checking in docs/release/system/ParserDB/ant15.jcb; new revision: 1.1.2.1; previous revision: 1.1 Checking in docs/release/system/ParserDB/ant15.jcs; new revision: 1.1.2.1; previous revision: 1.1 Checking in docs/src/org/apache/tools/ant/module/docs/Bundle.properties; new revision: 1.1.56.1; previous revision: 1.1 Checking in src/org/apache/tools/ant/module/resources/CustomTask_java; new revision: 1.5.54.1; previous revision: 1.5 Checking in src/org/apache/tools/ant/module/resources/SampleProject.xml_; new revision: 1.7.56.1; previous revision: 1.7
Note that 1.5.1 is already in beta. A couple of bugfixes (see URL).
The first development version of Ant NB modules for Ant1.5 can be found here: Ant module (ant.nbm): <http://ant.netbeans.org/servlets/ProjectDownloadList?action=download&dlID=226> Ant Documentation module (ant-docs.nbm): <http://ant.netbeans.org/servlets/ProjectDownloadList?action=download&dlID=227> The links are accessible also from Ant Home Page -> Files <http://ant.netbeans.org/servlets/ProjectDownloadList>. I tested it and everything seemed to work OK. But it is possible that there might be some bugs. This version does not contain any suport for new <input> task. Any feedback appreciated. In a few minutes I'm leaving my office and will be back in two weeks after my holiday. :-) So don't expect any answers from me or bugfixes sooner.
Jesper, Jesse Sorry, I should have responded earlier. I cannot remember the details of what broke, but following Jesper's instructions *did* work (actually, I got them from the FFJ email list). I *think* that I didn't find the proper workaround details before, or had finger trouble and gave up trying too early. (I'm lothe to start moving files around as I'm in the sort of environment where I can get disturbed, which can leave everything broken if I get part way thro'). I still can't get ant working properly, but I think that's a more fundamental configuration problem with my installation of Forte. Tim Coote
I will start building and testing the ANT 1.5 integration as part of my daily use/development of NetBeans since I need ANT 1.5-specific features. But, currently the build fails after the CVS scrambler merge. I think the ANT 1.5 integration branch needs to be updated to not use nbextra anymore. Also, do I need to pull ant15_integration from every module, or are all the changes localized to to the ANT module itself?
Brian, the ant15_integration branch is rooted from release34 branch so I cannot switch it to non-nbextra version. The branch contains only the Ant module. So I would recommend you to just download the two NBMs and install them into your NB. Once the work on branch is finished I will integrate it into main trunk.
XTesters: just FYI, I tested XTest and NetBeans trunk with the new module, and it looks like everything works. The only problem however is, that with the 1.5 module you cannot run test scripts directly from NetBeans IDE (because XTest still needs Ant 1.4.* to run the tests) - but this can be solved only if 1.5.1 will be backward compatible with 1.4 (1.5.0 is not) or 1.5 will become the official version for building NetBeans. Furthermore I don't see this as a major problem for XTest, because AFAIK most users are using command line way of running tests anyway ...
"but this can be solved only if 1.5.1 will be backward compatible with 1.4 (1.5.0 is not)" - whatever problems you have had with 1.5.0, I hope you have filed them in Jakarta's bug database...
Yes, I did and the fix was already commited to trunk as well as 1.5 branch (beta version of 1.5.1 already includes the fix). There also some other problems with 1.5, but AFAIK they are not caused by ant, but rather by XTest itself.
Just to pass my experience: Please do not forget bcel.jar in the ant 1.5.1 module. Otherwise the neat new core task >classfileset< will not work. bcel.jar is not delivered with ant 1.5.1 binary distribution. Rolf p.s. Currently I'm working with Jespers trick in order to have ant 1.5.1 available. How to fit bcel.jar into in the classpath of NB?
To David: jakarta.apache.org/bcel/ To Rolf: dump into modules/patches/org-apache-tools-ant-module/
1.5.1 was released.
positiv, thanks Jesse, >classfileset< works from within NB :))
The <classfileset> is _optional_ type. Why it should be handled differently than optional tasks? For all optional tasks you have to install their jars into folder Jesse mentioned. And I believe the same should be true for optional types.
Yes, it is an optional library - comes down to whether enough people would want to use it. We could consider a separate NBM containing just optional libraries. (ant-optional.jar does contain some tasks which don't need special libraries, so I would keep this in the main ant.nbm.)
Sounds reasonable. If there is enough interest we can do it.
Sources updated to Ant1.5.1, fixed a few links in documentation, <input> task handling implemented (UI needs to polish). Fixed in files: Checking in build.xml; new revision: 1.52.6.2.2.2; previous revision: 1.52.6.2.2.1 Checking in manifest.mf; new revision: 1.44.6.1.2.2; previous revision: 1.44.6.1.2.1 Checking in docs/manifest.mf; new revision: 1.1.56.2; previous revision: 1.1.56.1 Checking in docs/javahelp/org/apache/tools/ant/module/docs/HelpSet.hs; new revision: 1.1.56.2; previous revision: 1.1.56.1 Checking in docs/javahelp/org/apache/tools/ant/module/docs/Map.jhm; new revision: 1.1.56.2; previous revision: 1.1.56.1 Checking in docs/javahelp/org/apache/tools/ant/module/docs/TOC.toc; new revision: 1.1.56.2; previous revision: 1.1.56.1 Removing docs/release/system/ParserDB/ant15.jcb; Removing docs/release/system/ParserDB/ant15.jcs; Checking in docs/release/system/ParserDB/ant151.jcb; new revision: 1.1.2.1; previous revision: 1.1 Checking in docs/release/system/ParserDB/ant151.jcs; new revision: 1.1.2.1; previous revision: 1.1 Checking in docs/src/org/apache/tools/ant/module/docs/Bundle.properties; new revision: 1.1.56.2; previous revision: 1.1.56.1 Checking in src/org/apache/tools/ant/module/AntSettings.java; new revision: 1.16.56.1; previous revision: 1.16 Checking in src/org/apache/tools/ant/module/AntSettingsBeanInfo.java; new revision: 1.9.84.1; previous revision: 1.9 Checking in src/org/apache/tools/ant/module/Bundle.properties; new revision: 1.17.56.1; previous revision: 1.17 Checking in src/org/apache/tools/ant/module/resources/CustomTask_java; new revision: 1.5.54.2; previous revision: 1.5.54.1 Checking in src/org/apache/tools/ant/module/resources/SampleProject.xml_; new revision: 1.7.56.2; previous revision: 1.7.56.1 Checking in src/org/apache/tools/ant/module/run/Bundle.properties; new revision: 1.12.48.1; previous revision: 1.12 Checking in src/org/apache/tools/ant/module/run/NBInputHandler.java; new revision: 1.1.2.1; previous revision: 1.1 Checking in src/org/apache/tools/ant/module/run/TargetExecutor.java; new revision: 1.22.18.1; previous revision: 1.22
Jesse, I think it is almost done. What should be the next steps? I see following: 1.) QA cycle: build NBMs from my branch and ask QA to test them, fix bugs, etc. 2.) if everything is OK, put the NBMs on AutoUpdate + announce it on mailing lists 3.) merge branch into main trunk (+ do all what is necessary to do like scrambling etc.) 4.) file issue for documentation module to update docs and document new InputHandler dialog. 5.) misc issue: * update www/plans/plan.xml * submit patch for cvs://cvs.apache.org/jakarta-ant/xdocs/external.xml Is it all? Did I miss something?
Sounds like everything to me.
OK, I compiled new NBMs and uploaded them on Ant website <http://ant.netbeans.org/servlets/ProjectDownloadList>. Milan could you test them please? Download NBMs and install them into NB3.4. In AntSettings there should be new property "Input Handler". If empty the NB input handler will be used (see documentation for <input> task for more details). This is one area of new code. Second area is help system - there are several new links in Ant Documentation module. Also new tasks like <input> should have their help. The Ant Documentation module contains now full Ant JavaDoc and code completion for all Ant sources. That's all. Ask if you have any questions. Thanx in advance for testing. All other users are encouraged to test it as well. Once the NBMs are fully tested and without any bugs they will be uploaded to AutoUpdate center.
One feature that I liked in previous versions that seems to be missing in this current version is annotated name support. Since all the ant files are usually called build.xml it was nice that NB used to annotate the name of the project in the tree node as well as the editor tab. Since I usually have multiple build.xml files open at once it was a great feature and time saver. Aside from that, my build scripts seem to work fine with the latest nbms.
Note that if you select a build script in the Explorer, under 3.4 the project name will appear in the Explorer's mini status bar. The full path name is also shown in the tooltip on the Source Editor tab.
Yes, these features are good, but those in 3.3 were easier to use. Right now I can click on a tab, node, or file and see what it's about. Or I can wait for a tool tip (which usually takes longer than just clicking). If I can take a ms or two and see right away what build file is which, I can work that much faster. In all I really like NB's ant support, I'm just missing the feature that was included in ant 1.4.1 and NB 3.3.
Re. display of project name - well open a separate issue for it, no sense discussing it here. Perhaps the display style could be configurable. Having the project name always displayed can be annoying too, as it can consume a lot of space in the Explorer and Source Editor tabs. Ideally a user could control such things in Options using some kind of format, much like the adjustable formatting for Java source elements.
Jim: see issue 25793.
I did fast sanity check and it seems OK, except template for SampleProjects is not valid XML, it contains: <!-- Don't worry if you don't know the Ant syntax completely or need help on some tasks! --> <!-- The standard Ant documentation can be downloaded from AutoUpdate and <!-- and then you can access the help in menu Help | Help Sets | Ant 1.5.1 Manual. --> --> is missing there. I haven't executed automated tests neither did any test of ant 1.5.1 specific stuff so far.
Thanx. I fixed that problem and uploaded new version on the website. Btw. could you please try whether the default Ant input handlers work? I wanted to try them, but had some problems and did not have a time to try it again. The default handlers are: * org.apache.tools.ant.input.PropertyFileInputHandler * org.apache.tools.ant.input.DefaultInputHandler (if this one does not work I think it is OK, because it tries to read the input from stdout what won't work in NB) For more info about them consult Ant docs.
I was unable to install these new (fixed) NBMs. Was the rev number bumped?
I did not increase module version. That's the reason. In this case you have to unjar the ant.nbm file by hand and copy the ant.jar into your installation by hand. Hopefully this was last update and this won't happen again.
David, Is there any QA needed to test 1.5.1 integration? I mean, is there a need to write any automated test, or we should simply check the QA tests, written for 1.4.1. Sincere, Maxym
Set of automated tests for ant 1.4.1 was succesfully executed on NB 3.4 with ant 1.5.1 and also manual testing has been performed before putting module on AU center. IMO we should perform all those tests again after ant 1.5.1 becomes integral part of NB 3.4.1. Although there is no plan or timeframe for it.
Added this as a MUST HAVE in 3.4.1, 2 David: You're welcome to commit the appropriate fixes into relase341 branch after it will be created (I asked Jesse Glick ). 2 Jesse: Good morning ;-), you have a lot of CVS-aware TODOs for today, isn't it? Sincere, Maxym
BTW Maxym: you may want to start requiring use of the nbreviewers@netbeans.org list (netbeans.nbreviewers in NNTP) so people can track what is about to be committed to the branch when it is made, and have the opportunity to speak up about dangerous-looking fixes.
Created attachment 7928 [details] ant151 integration diff
Links to diffs (between release34 and ant15_integration branch): One diff file containing all the changes: <http://www.netbeans.org/issues/showattachment.cgi?attach_id=7928&file=ant151.diff> Added source files: <http://ant.netbeans.org/unbranded-source/browse/~checkout~/ant/src/org/apache/tools/ant/module/run/Attic/NBInputHandler.java?rev=1.1.2.2&content-type=text/plain> Modified binary files: nbextra/ant/ant-docs.zip Added binary files: ant/docs/release/system/ParserDB/ant151.jcb ant/docs/release/system/ParserDB/ant151.jcs nbextra/ant/release/modules/ext/ant-1.5.1.jar nbextra/ant/release/modules/ext/ant-optional-1.5.1.jar Removed binary files: ant/docs/release/system/ParserDB/ant141.jcb ant/docs/release/system/ParserDB/ant141.jcs nbextra/ant/release/modules/ext/ant-1.4.1.jar nbextra/ant/release/modules/ext/ant-optional-1.4.1.jar
I looked over the attached diff - it looks good to me.
David, please, you are welcome to integrate this issue into release341 branch. Or there must be more reviews?
OK, I will integrate it (and other Ant issues) early next week.
How can I lead Ant to get bcel.jar into its classpath when started? For the optional Ant-type "classFileSet" bcel.jar is needed. When I start ant from the commandline it includes all jars that it finds in its lib directory. Obviosly it doesn't do that when invoked from within netbeans. Rolf
Integrated into 3.4.1 branch. Closing as fixed. Integration into main trunk will follow tomorrow.
Integrated into main trunk as well.
Patch for Ant site requesting version update was filed as <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15838>. This was the last missing issue.