This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 230551 - Inspect mode checkbox not functional after switching browser
Summary: Inspect mode checkbox not functional after switching browser
Status: RESOLVED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Extbrowser (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Jan Stola
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 20:49 UTC by Petr Jiricka
Modified: 2013-05-31 20:14 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2013-05-30 20:49:06 UTC
1. Create a HTML5 application
2. Run it in Chrome with NetBeans integration
3. Switch the browser to e.g. Firefox in the IDE. The yellow infobar in Chrome disappears as a result, as the IDE terminates the connection to Chrome - this is expected. But:

=> Click on the NetBeans icon in the address bar. The Inspect in NetBeans Mode checkbox is still there, but is not functional and does nothing.

Not sure what the correct behavior should be, possibly just hide the NetBeans icon in the address bar, like we do when the user closes the yellow infobar? Or keep the icon there, just remove this checkbox?
Comment 1 Petr Jiricka 2013-05-30 21:01:21 UTC
This issue will get even worse when the user turns off the yellow debugging infobar - see bug 230292 for background. Because when the yellow bar is shown initially, the user can figure out that the connection to the IDE was disconnected, by seeing it disappear. 

When the yellow infobar is hidden from the start, then there is nothing to disappear, and the user can't tell the difference this way. So it will be harder for her to figure out why the Inspect in NetBeans Mode stopped working.
Comment 2 David Konecny 2013-05-30 21:34:18 UTC
Inspect mode checkbox should be shown (or enabled) only when Webkit Debugging session is established between IDE and browser tab.
Comment 3 David Konecny 2013-05-30 21:37:17 UTC
I thought this was resolved by issue 227975.
Comment 4 Petr Jiricka 2013-05-31 09:15:08 UTC
Apparently not.
Comment 5 Jan Stola 2013-05-31 15:06:41 UTC
I have modified the corresponding code to hide the Inspect Mode checkbox and Inspect Mode context menu item when there is no debug session. Namely, they are hidden when
* the yellow debugging infobar is closed
* when the browser is switched
* when the page is executed in Chrome without NetBeans integration

Modified files: http://hg.netbeans.org/web-main/rev/ac578e76001c
Comment 6 Petr Jiricka 2013-05-31 20:14:07 UTC
Thanks a lot Honzo, I can verify that the following use cases now work well for me:

> * when the browser is switched
> * when the page is executed in Chrome without NetBeans integration

However, I can not confirm/verify this use case:

> * the yellow debugging infobar is closed

Because in that case, the NetBeans icon disappears completely. Likewise, when I open Chrome Developer Tools, the NetBeans icon disappears completely - instead it should stay there with the Inspect checkbox (plus item in the popup menu) removed. See also bug 229317 for a discussion about this case.

Thanks.