Thanks for catching that, will have a look at it.

The problem here are the "non-numeric" suffixes (e.g. "rc6") - even cdnjs.com is not corectly sorted. Our API class Version fails on it.

Adding PetrH to CC (at least he seems to be the @author of this class ;) - Petře, we use:

Version.fromDottedNotationWithFallback("1.0.0rc6");

For this Version, method Version.isBelowOrEqual(Version) always returns false if the other Version is "numeric only".

The question is what to do with it :) Version "1.0rc" is expected to be "older" than "1.0" but OTOH, "1.0u1" (or similarly) is expected to be "newer" than "1.0" - unfortunately I don't think we can correctly handle all cases.

I tried to "sanitize" library version passed to Version class, the result is:

> angular.js 1.0.0rc6 instead of 1.1.5

works

> backbone.js 0.9.9-amdjs instead of 1.0.0

works

> ember.js 1.0pre instead of 1.0.0-rc.4

does not work

> headjs 0.97a instead of 0.99

works

> mustache.js 0.5.0-dev instead of 0.7.2

works

> handlebars.js 1.0.rc.2 instead of 1.0.0-rc.4

does not work


Closing as FIXED but of course, feel free to reopen if anyone of you have a better idea.

Thanks.

http://hg.netbeans.org/web-main/rev/abfcb187fa93

Thanks a lot. So I assume when ember 1.0 and handlebars 1.0 are released, these cases will also work as expected, right?

Yes. The only thing I do now is that I simply remove everything after first "not-number-or-dot" ([^.0-9]) character. But I have also noticed that the version can be "latest" - here cannot be done anything...

Thanks.

Integrated into 'main-golden', will be available in build *201305312301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/abfcb187fa93
User: Tomas Mysik <tmysik@netbeans.org>
Log: #230467 - Order of versions of JavaScript libraries is incorrect and does not match the order at cdnjs.com

I still found another minor problem, using the latest snapshot bundled with the IDE:
ember.js 1.0.0-rc.4 is at the top and preselected, when 1.0.0-rc.7 is also available in the snapshot. This should be doable, no? (The cdnjs shows the order correctly for these.)

Reopening as a P4.

Unfortunately not. See comment #c2 and comment #c4 for explanation (our API class Version need to support non-numeric versions - as "rc" etc. - as well).

Thanks.

Issue against Version class reported as issue #235414. Keeping this opened as a reminder (the changeset that fixes this issue can be reverted).

Thanks.

Ok, I understand we want to reuse the Version class and not reinvent the wheel for this. I can imagine that even without the implementation of enhancement 235414, a solution like this could work for this case:
Step 1: Compare the part before the first "not-number-or-dot"
Step 2: If they are equal, find a common prefix of the two strings
Step 3: If it's non-empty, remove this common prefix
Step 4: If the remainders of both strings start with number or dot, pass these remainders back to step 1

But it may not be worth the effort.

Yes, I was thinking about it first - but as you write, I think that this should be in Version so everyone can benefit from it. CDNJS is maybe even more complicated since authors can release any versions they like (e.g. "pre", "1.0a" or just "latest" etc.) and it is not possible to compare them always correctly (I can imagine that "1.0a" can be older but also newer than "1.0").

Thanks.

Basically fixed as part of issue #243494.

Thanks.

http://hg.netbeans.org/web-main/rev/a385faff0266

Integrated into 'main-silver', will be available in build *201404050001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a385faff0266
User: Tomas Mysik <tmysik@netbeans.org>
Log: #243494 - IllegalArgumentException: Comparison method violates its general contract!

It fixes #230467 as well.

Integrated into 'releases/release80', will be available in build *201404240045* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/d1b22ce758c2
User: Tomas Mysik <tmysik@netbeans.org>
Log: #243494 - IllegalArgumentException: Comparison method violates its general contract!

It fixes #230467 as well.
(transplanted from a385faff02663b79677c4b5bc23cf5ffb9acf08a)