This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 230383 - [dark] Review editor colors of HTML and CSS code for dark color schemes (Norway Today and City Lights)
Summary: [dark] Review editor colors of HTML and CSS code for dark color schemes (Norw...
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Editor (show other bugs)
Version: 7.4
Hardware: All All
: P3 normal (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-28 13:25 UTC by Petr Jiricka
Modified: 2013-06-08 01:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2013-05-28 13:25:12 UTC 
See subj.
Comment 1 Marek Fukala 2013-06-05 14:47:56 UTC 
I've fixed the at-rule symbols coloring for those dark themes. It used to be black which made the text almost invisible. 

All of the semantic colorings for the dark themes are inherited from the CSL defaults which looks quite fine.

I've also checked embedded css and javascript in html + semantic colorings for the html frameworks => all looks quite fine.

I'm closing the issue as fixed as I do not see an apparent fault now.  OTOH if anyone with a better sense to colors invests his/her time to do a "full review" then please reopen and assign to him/herself.

web-main#7f8d634c53ca
Comment 2 Tomas Mysik 2013-06-07 08:59:45 UTC 
Just noticed that "{{" and "}}" are not visible at all (they are black). Should I reopen this issue? I think there will be some deeper, overall testing of dark theme...

Thanks.
Comment 3 Marek Fukala 2013-06-07 09:14:42 UTC 
>Just noticed that "{{" and "}}" are not visible at all (they are black)
Thanks, will fix
Comment 4 Marek Fukala 2013-06-07 09:32:06 UTC 
changeset:   255356:17c12a62be48
summary:     better colors for EL in html for dark themes
Comment 5 Quality Engineering 2013-06-08 01:08:20 UTC 
Integrated into 'main-golden', will be available in build *201306072301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/7f8d634c53ca
User: Marek Fukala <mfukala@netbeans.org>
Log: #230383 - Review editor colors of HTML and CSS code for dark color schemes (Norway Today and City Lights)