This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229724 - Remove Knockout stuff from the code completion for non-KO files
Summary: Remove Knockout stuff from the code completion for non-KO files
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: Knockout (show other bugs)
Version: 7.4
Hardware: PC Mac OS X
: P2 normal (vote)
Assignee: Petr Hejl
URL:
Keywords:
: 229883 (view as bug list)
Depends on:
Blocks: 229318
  Show dependency tree
 
Reported: 2013-05-14 13:10 UTC by Marek Fukala
Modified: 2013-05-28 09:48 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Fukala 2013-05-14 13:10:33 UTC 
Right now, some internal KO's objects like $root, $data etc. are shown for any js code in html file.

Similar situation may be for angular.

I need to rewrite the JsEmbeddingProvider to operate with HtmlParserResult so we can use KOModel/AngularModel.isKO/AngularFile() in the JsEmbeddingProviderPlugins.
Comment 1 Petr Hejl 2013-05-14 13:23:57 UTC 
Might be related: #229432.
Comment 2 Vladimir Riha 2013-05-17 07:29:31 UTC 
*** Bug 229883 has been marked as a duplicate of this bug. ***
Comment 3 Marek Fukala 2013-05-22 09:05:31 UTC 
changeset:   253787:28bdbdcc6929
summary:     no KO javascript embedding for plain html files

Unfortunately even when I effectively disable the JsEmbeddingProvider to create the KO's virtual JS source, the $root, $data and $parent KO objects are still preset in the completion => passing to PetrH.
Comment 4 Petr Hejl 2013-05-28 09:48:04 UTC 
Should be fixed by bde4058e463e (fix for #229851).