This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229689 - Add help for directives to the internal completion documentation window
Summary: Add help for directives to the internal completion documentation window
Status: VERIFIED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: AngularJS (show other bugs)
Version: 7.4
Hardware: PC Mac OS X
: P1 normal (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-14 05:58 UTC by Marek Fukala
Modified: 2013-07-11 04:12 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Fukala 2013-05-14 05:58:49 UTC
So far the only "open in external browser" works in the completion documentation.
Comment 1 Marek Fukala 2013-07-01 09:47:40 UTC
Using the embedded browser for rendering AJS doc: web-main#0d80e1df5d8e. The documentation is built (downloaded and rendered) per IDE's JVM session - a local caching of the rendered doc is still necessary. I'll implement it along with the KO's help which is also loaded from the online web.

Once one asks for a doc for a AJS directive, documentation for *all* directives is built in one task (there's a progress bar for the task as well). It takes quite long time, but the reason is that creating the embedded browser is quite costly so doing it per partes wouldn't possibly work worser.
Comment 2 Quality Engineering 2013-07-02 02:16:06 UTC
Integrated into 'main-silver', will be available in build *201307012300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/0d80e1df5d8e
User: Marek Fukala <mfukala@netbeans.org>
Log: #229689 - Add help for directives to the internal completion documentation window
Comment 3 Vladimir Riha 2013-07-02 06:48:20 UTC
I tried it and it works OK, but during the building process (and it looks like also after it finished - meaning progress bar is already hidden), it throws IOException several times. Exception report [1] has been added to existing issue 225306.



[1] http://statistics.netbeans.org/exceptions/exception.do?id=679302
Comment 4 Vladimir Riha 2013-07-02 07:17:36 UTC
This exception keep popping up even when IDE is "idle". Is it possible to somehow fix it? (strip the html page prior its usage to remove the disqus content, or use partials [1] instead) 

[1] http://code.angularjs.org/1.0.7/docs/partials/api/
Comment 5 Marek Fukala 2013-07-02 14:07:01 UTC
Vlado, I'll try to address it somehow. It happens to me as well.
Comment 6 Vladimir Riha 2013-07-04 12:27:59 UTC
Thank you in advance. I think this (if possible) should be resolved for Beta as the exceptions are a bit often even when there is no Angular project anymore => P2
Comment 7 Vladimir Riha 2013-07-08 09:13:08 UTC
I think this is stopper for Beta => P1
Comment 8 Marek Fukala 2013-07-08 12:24:58 UTC
I cannot think of any other solution than filtering out the addresses which returns the "I'm a teapot" http code. I believe this needs to be addressed somehow in the JDK's embedded browser - Bug 225306
Comment 9 Marek Fukala 2013-07-08 15:04:33 UTC
hopefully fixed in web-main#e1301380a0db

I tried several strategies - loading the doc content to a local file w/o the offending content, but the page won't run(render) from local URL, then tried to fiddle with the offending logger - couldn't effectively disable it either and finally played with the browser and tried some tricks ... and it seems the last one was successful :-) At least I cannot reproduce now.

Please verify so I can possible transplant to beta. Thank you Vlado.
Comment 10 Vladimir Riha 2013-07-09 09:34:39 UTC
Unfortunately still reproducible (see [1]) but it seems to be better now. I initiated documentation building in yesterday's trunk and today's web main and let IDE 10 minutes idle. Trunk (w/o fix) throws exception approx. once per minute. Web-main build threw it only once in 17 minutes period. I tried web-main with fresh user dir again with similar result (I gave up waiting after 10 minutes), then I restarted IDE and again trigger documentation building and got the exception twice in short time. Then I tried it again and no exception was thrown...

So it is better, but not completely fixed. If we let AngularJS help feature in Beta, even with this partial fix there will be more duplicates of issue 225306 coming (especially as the Angular help seems to be rebuilded after IDE restart). I'm not sure if it wouldn't be better to remove it from Beta if it cannot be fixed completely?


[1] http://statistics.netbeans.org/exceptions/exception.do?id=680257
Comment 11 Vladimir Riha 2013-07-09 09:50:41 UTC
After discussion with Marek, Marek promised to look at it one more time and remove it from Beta if there will be no better way to fix it.
Comment 12 Marek Fukala 2013-07-09 12:13:22 UTC
changeset:   257919:1824098bf8f5
summary:     #229689 - removing the rendering of the AJS documentation by the embedded browser due to the "I'm a teapot" http code being reported as a serious error. As a temporary solution the partial files are used.
Comment 13 Marek Fukala 2013-07-09 12:17:00 UTC
If the solution using embedded browser is restored then please reopen Bug 232441 - netscape.javascript.JSException: TypeError: 'null' is not an object
Comment 14 Vladimir Riha 2013-07-09 15:42:05 UTC
Thank you, I tried 3 times following case: start IDE with fresh user dir, trigger documentation building, let it be few minutes, restart IDE, works with IDE few minutes. I haven't seen single exception in all cases. 

Please transplant it to Beta. Thank you


Product Version: NetBeans IDE Dev (Build web-main-11016-on-20130709)
Java: 1.7.0_25; Java HotSpot(TM) Client VM 23.25-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b15
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 15 David Strupl 2013-07-09 16:01:50 UTC
Can this be transplanted to releases (to the release74_beta1 branch) today by 10PM so it
is in tomorrows beta build? Thanks.
Comment 16 Marek Fukala 2013-07-09 16:19:07 UTC
changeset:   266366:0f3b88b81309
branch:      release74_beta1
summary:     #229689 - removing the rendering of the AJS documentation by the embedded browser due to the "I'm a teapot" http code being reported as a serious error. As a temporary solution the partial files are used.

changeset:   266367:3f803edface9
branch:      release74_beta1
date:        Tue Jul 09 18:18:13 2013 +0200
summary:     removing dependency to core.browser
Comment 17 Quality Engineering 2013-07-10 02:43:36 UTC
Integrated into 'releases/release74_beta1', will be available in build *201307092200* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/0f3b88b81309
User: Marek Fukala <mfukala@netbeans.org>
Log: #229689 - removing the rendering of the AJS documentation by the embedded browser due to the "I'm a teapot" http code being reported as a serious error. As a temporary solution the partial files are used.
Comment 18 Quality Engineering 2013-07-10 04:43:52 UTC
Integrated into 'main-silver', will be available in build *201307100049* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/e1301380a0db
User: Marek Fukala <mfukala@netbeans.org>
Log: #229689 - Add help for directives to the internal completion documentation window
Comment 19 Vladimir Riha 2013-07-10 10:31:25 UTC
Verified in Beta

Product Version: NetBeans IDE 7.4 Beta (Build 201307092200)
Java: 1.7.0_25; Java HotSpot(TM) Client VM 23.25-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b15
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 20 Quality Engineering 2013-07-11 04:12:44 UTC
Integrated into 'main-silver', will be available in build *201307102300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/1824098bf8f5
User: Marek Fukala <mfukala@netbeans.org>
Log: #229689 - removing the rendering of the AJS documentation by the embedded browser due to the "I'm a teapot" http code being reported as a serious error. As a temporary solution the partial files are used.