This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229265 - Patch for: Quicksearch field in new project/new file wizard should be focused by default
Summary: Patch for: Quicksearch field in new project/new file wizard should be focused...
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Projects UI (show other bugs)
Version: 7.4
Hardware: PC Mac OS X
: P3 normal (vote)
Assignee: Martin Kozeny
URL:
Keywords: A11Y, PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-05-02 09:13 UTC by Tomas Danek
Modified: 2013-08-29 01:40 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Proposed patch (2.22 KB, patch)
2013-06-19 15:37 UTC, markiewb 		Details | Diff
Patch in action (71.40 KB, image/png)
2013-06-19 15:38 UTC, markiewb 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Danek 2013-05-02 09:13:07 UTC 
..to make navigation more simple.
Comment 1 Milos Kleint 2013-05-06 07:19:26 UTC 
the current code explicitly focuses the category component. Maybe it's working as designed?
Comment 2 markiewb 2013-05-10 17:28:07 UTC 
IMHO the quicksearch field should also have a label with a mnemonic. OR the quicksearch field should only be visible if the user typed some chars...
Comment 3 Milos Kleint 2013-06-12 14:47:41 UTC 
as far as I can tell it works as intended. filtering is optional action, primary is template selection.
Comment 4 markiewb 2013-06-12 21:32:17 UTC 
@Milos: How about adding a label with a mnemonic for the search textfield?
Comment 5 markiewb 2013-06-19 15:37:42 UTC 
Created attachment 136039 [details]
Proposed patch

(In reply to comment #4)
> @Milos: How about adding a label with a mnemonic for the search textfield?

I like to propose a patch to solve my own previous proposal. The patch adds a label "Filter: " to the magnifier icon. See screenshot.
The code is more like a hack. But this type of access to the inner components of the quicksearch widgethas been used several times in the already existing class. So it is also OK for me. 

@Milos: What do think about? Please review and commit if appropriate.
Comment 6 markiewb 2013-06-19 15:38:09 UTC 
Created attachment 136040 [details]
Patch in action
Comment 7 Milos Kleint 2013-06-26 08:17:11 UTC 
adding saubrecht on CC, QuickSearch api we use is in org.openide.awt. Maybe the label/mnemonics should be added to the default implementation?
Comment 8 Milos Kleint 2013-07-01 09:46:30 UTC 
FYI the patch doesn't include a label text on macosx as the components there don't include a label with icon (as the icon is embedded in the textfield)
Comment 9 markiewb 2013-07-01 18:08:10 UTC 
(In reply to comment #8)
> FYI the patch doesn't include a label text on macosx as the components there
> don't include a label with icon (as the icon is embedded in the textfield)

@Milos: I don't have access to a Mac so I cannot extend the patch to support the MacOS specifics. Only FYI
Comment 10 Martin Kozeny 2013-08-28 15:00:33 UTC 
https://hg.netbeans.org/core-main/rev/e45044e9e373
Comment 11 Quality Engineering 2013-08-29 01:40:49 UTC 
Integrated into 'main-silver', will be available in build *201308290001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/e45044e9e373
User: Martin Kozeny <mkozeny@netbeans.org>
Log: #229265: Patch for: Quicksearch field in new project/new file wizard label with mnemonic.